From bb8cf8eca8c3306048a0d931f4ab8d2ef3202324 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 22 Dec 2015 18:20:23 -0800 Subject: [PATCH] Fix incorrect rendering of "Spaces" dropdown control when configuring EditEngine defaults Summary: Ref T10004. This could sometimes pass `false`, which counts as disabled. Instead, pass `null` explicitly. Test Plan: Edited default space on an EditEngine form. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10004 Differential Revision: https://secure.phabricator.com/D14858 --- src/view/form/control/AphrontFormPolicyControl.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/view/form/control/AphrontFormPolicyControl.php b/src/view/form/control/AphrontFormPolicyControl.php index c78d72f25f..348dc8171f 100644 --- a/src/view/form/control/AphrontFormPolicyControl.php +++ b/src/view/form/control/AphrontFormPolicyControl.php @@ -351,7 +351,7 @@ final class AphrontFormPolicyControl extends AphrontFormControl { $viewer, $space_phid), array( - 'disabled' => $this->getDisabled(), + 'disabled' => ($this->getDisabled() ? 'disabled' : null), 'name' => 'spacePHID', 'class' => 'aphront-space-select-control-knob', ));