From bb9b25a7ba799d43ea4dfeafac57014a56c5f554 Mon Sep 17 00:00:00 2001
From: Joshua Spence <josh@freelancer.com>
Date: Thu, 12 Nov 2015 06:33:38 +1100
Subject: [PATCH] Remove the `PhortuneNotImplementedException` class

Summary: Replace `PhortuneNotImplementedException` with `PhutilMethodNotImplementedException`.

Test Plan: N/A

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14445
---
 src/__phutil_library_map__.php                   |  2 --
 .../PhortuneNotImplementedException.php          | 12 ------------
 .../provider/PhortunePaymentProvider.php         | 16 ++++++++--------
 3 files changed, 8 insertions(+), 22 deletions(-)
 delete mode 100644 src/applications/phortune/exception/PhortuneNotImplementedException.php

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index c89cb75f70..a28863b4ac 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -3428,7 +3428,6 @@ phutil_register_library_map(array(
     'PhortuneMerchantTransactionQuery' => 'applications/phortune/query/PhortuneMerchantTransactionQuery.php',
     'PhortuneMerchantViewController' => 'applications/phortune/controller/PhortuneMerchantViewController.php',
     'PhortuneMonthYearExpiryControl' => 'applications/phortune/control/PhortuneMonthYearExpiryControl.php',
-    'PhortuneNotImplementedException' => 'applications/phortune/exception/PhortuneNotImplementedException.php',
     'PhortuneOrderTableView' => 'applications/phortune/view/PhortuneOrderTableView.php',
     'PhortunePayPalPaymentProvider' => 'applications/phortune/provider/PhortunePayPalPaymentProvider.php',
     'PhortunePaymentMethod' => 'applications/phortune/storage/PhortunePaymentMethod.php',
@@ -7771,7 +7770,6 @@ phutil_register_library_map(array(
     'PhortuneMerchantTransactionQuery' => 'PhabricatorApplicationTransactionQuery',
     'PhortuneMerchantViewController' => 'PhortuneMerchantController',
     'PhortuneMonthYearExpiryControl' => 'AphrontFormControl',
-    'PhortuneNotImplementedException' => 'Exception',
     'PhortuneOrderTableView' => 'AphrontView',
     'PhortunePayPalPaymentProvider' => 'PhortunePaymentProvider',
     'PhortunePaymentMethod' => array(
diff --git a/src/applications/phortune/exception/PhortuneNotImplementedException.php b/src/applications/phortune/exception/PhortuneNotImplementedException.php
deleted file mode 100644
index eac3b3b7a8..0000000000
--- a/src/applications/phortune/exception/PhortuneNotImplementedException.php
+++ /dev/null
@@ -1,12 +0,0 @@
-<?php
-
-final class PhortuneNotImplementedException extends Exception {
-
-  public function __construct(PhortunePaymentProvider $provider) {
-    return parent::__construct(
-      pht(
-        "Provider '%s' does not implement this method.",
-        get_class($provider)));
-  }
-
-}
diff --git a/src/applications/phortune/provider/PhortunePaymentProvider.php b/src/applications/phortune/provider/PhortunePaymentProvider.php
index 8e25d134b0..90e354c5dc 100644
--- a/src/applications/phortune/provider/PhortunePaymentProvider.php
+++ b/src/applications/phortune/provider/PhortunePaymentProvider.php
@@ -109,7 +109,7 @@ abstract class PhortunePaymentProvider extends Phobject {
   abstract public function canRunConfigurationTest();
 
   public function runConfigurationTest() {
-    throw new PhortuneNotImplementedException($this);
+    throw new PhutilMethodNotImplementedException();
   }
 
 
@@ -169,7 +169,7 @@ abstract class PhortunePaymentProvider extends Phobject {
    * @task addmethod
    */
   public function translateCreatePaymentMethodErrorCode($error_code) {
-    throw new PhortuneNotImplementedException($this);
+    throw new PhutilMethodNotImplementedException();
   }
 
 
@@ -177,7 +177,7 @@ abstract class PhortunePaymentProvider extends Phobject {
    * @task addmethod
    */
   public function getCreatePaymentMethodErrorMessage($error_code) {
-    throw new PhortuneNotImplementedException($this);
+    throw new PhutilMethodNotImplementedException();
   }
 
 
@@ -185,7 +185,7 @@ abstract class PhortunePaymentProvider extends Phobject {
    * @task addmethod
    */
   public function validateCreatePaymentMethodToken(array $token) {
-    throw new PhortuneNotImplementedException($this);
+    throw new PhutilMethodNotImplementedException();
   }
 
 
@@ -196,7 +196,7 @@ abstract class PhortunePaymentProvider extends Phobject {
     AphrontRequest $request,
     PhortunePaymentMethod $method,
     array $token) {
-    throw new PhortuneNotImplementedException($this);
+    throw new PhutilMethodNotImplementedException();
   }
 
 
@@ -206,12 +206,12 @@ abstract class PhortunePaymentProvider extends Phobject {
   public function renderCreatePaymentMethodForm(
     AphrontRequest $request,
     array $errors) {
-    throw new PhortuneNotImplementedException($this);
+    throw new PhutilMethodNotImplementedException();
   }
 
   public function getDefaultPaymentMethodDisplayName(
     PhortunePaymentMethod $method) {
-    throw new PhortuneNotImplementedException($this);
+    throw new PhutilMethodNotImplementedException();
   }
 
 
@@ -290,7 +290,7 @@ abstract class PhortunePaymentProvider extends Phobject {
   public function processControllerRequest(
     PhortuneProviderActionController $controller,
     AphrontRequest $request) {
-    throw new PhortuneNotImplementedException($this);
+    throw new PhutilMethodNotImplementedException();
   }
 
 }