revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-18 12:52:42 +01:00
Code Issues Releases Wiki Activity

Fix task graph fatal for graphs containing restricted tasks

Browse source 
Summary: Fixes T11392. If some tasks are restricted, we only have PHIDs for them, not objects. Just use the PHIDs instead.

Test Plan: {F1741335}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11392

Differential Revision: https://secure.phabricator.com/D16345
This commit is contained in:
epriestley 2016-07-29 07:02:36 -07:00
parent 15c7eb1425
commit bbc2ae7858
1 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/infrastructure/graph/ManiphestTaskGraph.php
View file

@ -74,12 +74,10 @@ final class ManiphestTaskGraph
$link = $viewer->renderHandle($phid); $link = $viewer->renderHandle($phid);
} }
if ($this->isParentTask($phid)) {
if ($this->isParentTask($object)) {
$marker = 'fa-chevron-circle-up bluegrey'; $marker = 'fa-chevron-circle-up bluegrey';
$marker_tip = pht('Direct Parent'); $marker_tip = pht('Direct Parent');
} else if ($this->isChildTask($object)) { } else if ($this->isChildTask($phid)) {
$marker = 'fa-chevron-circle-down bluegrey'; $marker = 'fa-chevron-circle-down bluegrey';
$marker_tip = pht('Direct Subtask'); $marker_tip = pht('Direct Subtask');
} else { } else {
@ -128,14 +126,14 @@ final class ManiphestTaskGraph
)); ));
} }
private function isParentTask(ManiphestTask $task) { private function isParentTask($task_phid) {
$map = $this->getSeedMap(ManiphestTaskDependedOnByTaskEdgeType::EDGECONST); $map = $this->getSeedMap(ManiphestTaskDependedOnByTaskEdgeType::EDGECONST);
return isset($map[$task->getPHID()]); return isset($map[$task_phid]);
} }
private function isChildTask(ManiphestTask $task) { private function isChildTask($task_phid) {
$map = $this->getSeedMap(ManiphestTaskDependsOnTaskEdgeType::EDGECONST); $map = $this->getSeedMap(ManiphestTaskDependsOnTaskEdgeType::EDGECONST);
return isset($map[$task->getPHID()]); return isset($map[$task_phid]);
} }
private function getSeedMap($type) { private function getSeedMap($type) {