mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-22 06:42:42 +01:00
Remove addExtraQuicksandConfig
Summary: Removes all calls to addExtraQuicksandConfig Ref T9690 Test Plan: grep for addExtraQuicksandConfig, view a Pholio Page with and without chatbar, edit a pholio mock, save mock. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T9690 Differential Revision: https://secure.phabricator.com/D14622
This commit is contained in:
parent
774d2db8dc
commit
bbd1da4f8d
3 changed files with 4 additions and 24 deletions
|
@ -463,9 +463,6 @@ abstract class PhabricatorController extends AphrontController {
|
|||
$page->setUser($viewer);
|
||||
}
|
||||
|
||||
// TODO: Remove after removing callsites to addExtraQuicksandConfig().
|
||||
$page->addQuicksandConfig($this->extraQuicksandConfig);
|
||||
|
||||
return $page;
|
||||
}
|
||||
|
||||
|
@ -533,22 +530,6 @@ abstract class PhabricatorController extends AphrontController {
|
|||
/* -( Deprecated )--------------------------------------------------------- */
|
||||
|
||||
|
||||
/**
|
||||
* DEPRECATED.
|
||||
*/
|
||||
private $extraQuicksandConfig = array();
|
||||
|
||||
|
||||
/**
|
||||
* DEPRECATED. Use @{method:newPage} and call addQuicksandConfig().
|
||||
*/
|
||||
public function addExtraQuicksandConfig($config) {
|
||||
// TODO: When this method is removed,
|
||||
$this->extraQuicksandConfig += $config;
|
||||
return $this;
|
||||
}
|
||||
|
||||
|
||||
/**
|
||||
* DEPRECATED. Use @{method:newPage}.
|
||||
*/
|
||||
|
|
|
@ -382,12 +382,11 @@ final class PholioMockEditController extends PholioController {
|
|||
$form_box,
|
||||
);
|
||||
|
||||
$this->addExtraQuicksandConfig(
|
||||
array('mockEditConfig' => true));
|
||||
|
||||
return $this->newPage()
|
||||
->setTitle($title)
|
||||
->setCrumbs($crumbs)
|
||||
->addQuicksandConfig(
|
||||
array('mockEditConfig' => true))
|
||||
->appendChild(
|
||||
array(
|
||||
$form_box,
|
||||
|
|
|
@ -78,8 +78,6 @@ final class PholioMockViewController extends PholioController {
|
|||
->setUser($viewer)
|
||||
->setMock($mock)
|
||||
->setImageID($image_id);
|
||||
$this->addExtraQuicksandConfig(
|
||||
array('mockViewConfig' => $mock_view->getBehaviorConfig()));
|
||||
|
||||
$output = id(new PHUIObjectBoxView())
|
||||
->setHeaderText(pht('Image'))
|
||||
|
@ -102,6 +100,8 @@ final class PholioMockViewController extends PholioController {
|
|||
->setTitle('M'.$mock->getID().' '.$title)
|
||||
->setCrumbs($crumbs)
|
||||
->setPageObjectPHIDs(array($mock->getPHID()))
|
||||
->addQuicksandConfig(
|
||||
array('mockViewConfig' => $mock_view->getBehaviorConfig()))
|
||||
->appendChild(
|
||||
array(
|
||||
$object_box,
|
||||
|
|
Loading…
Reference in a new issue