revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 13:22:42 +01:00
Code Issues Releases Wiki Activity

Examine fewer daemons for variant config

Browse source 
Summary:
Right now, if a daemon dies it can leave the setup warning around for like 10 minutes or something until we reap it.

Tighten the warning so we only care about actively running daemons.

Test Plan: Checked setup issues.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D12088
This commit is contained in:
epriestley 2015-03-15 11:31:07 -07:00
parent 106ca70acb
commit bc28b2c3a8
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/config/check/PhabricatorDaemonsSetupCheck.php
View file

@ -10,7 +10,7 @@ final class PhabricatorDaemonsSetupCheck extends PhabricatorSetupCheck {
$task_daemon = id(new PhabricatorDaemonLogQuery()) $task_daemon = id(new PhabricatorDaemonLogQuery())
->setViewer(PhabricatorUser::getOmnipotentUser()) ->setViewer(PhabricatorUser::getOmnipotentUser())
->withStatus(PhabricatorDaemonLogQuery::STATUS_ALIVE) ->withStatus(PhabricatorDaemonLogQuery::STATUS_RUNNING)
->withDaemonClasses(array('PhabricatorTaskmasterDaemon')) ->withDaemonClasses(array('PhabricatorTaskmasterDaemon'))
->setLimit(1) ->setLimit(1)
->execute(); ->execute();

5
src/applications/daemon/query/PhabricatorDaemonLogQuery.php
View file

@ -5,6 +5,7 @@ final class PhabricatorDaemonLogQuery
const STATUS_ALL = 'status-all'; const STATUS_ALL = 'status-all';
const STATUS_ALIVE = 'status-alive'; const STATUS_ALIVE = 'status-alive';
const STATUS_RUNNING = 'status-running';
private $ids; private $ids;
private $notIDs; private $notIDs;
@ -170,6 +171,10 @@ final class PhabricatorDaemonLogQuery
switch ($status) { switch ($status) {
case self::STATUS_ALL: case self::STATUS_ALL:
return array(); return array();
case self::STATUS_RUNNING:
return array(
PhabricatorDaemonLog::STATUS_RUNNING,
);
case self::STATUS_ALIVE: case self::STATUS_ALIVE:
return array( return array(
PhabricatorDaemonLog::STATUS_UNKNOWN, PhabricatorDaemonLog::STATUS_UNKNOWN,