revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 23:02:42 +01:00
Code Issues Releases Wiki Activity

Replace elseif by else if

Browse source 
Summary:
Mostly written by me.
Omit external libraries.

Test Plan: http://phabricator.com/docs/phabricator/article/PHP_Coding_Standards.html

Reviewers: epriestley

Reviewed By: epriestley

CC: aran

Differential Revision: https://secure.phabricator.com/D2104
This commit is contained in:
vrana 2012-04-04 15:06:45 -07:00
parent b8cb52a9da
commit bc61f36beb
5 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/differential/controller/revisionlist/DifferentialRevisionListController.php
View file

@ -406,9 +406,9 @@ final class DifferentialRevisionListController extends DifferentialController {
case 'status':
if ($params['status'] == 'open') {
$query->withStatus(DifferentialRevisionQuery::STATUS_OPEN);
} elseif ($params['status'] == 'committed') {
} else if ($params['status'] == 'committed') {
$query->withStatus(DifferentialRevisionQuery::STATUS_COMMITTED);
} elseif ($params['status'] == 'abandoned') {
} else if ($params['status'] == 'abandoned') {
$query->withStatus(DifferentialRevisionQuery::STATUS_ABANDONED);
}
break;

4
src/applications/differential/parser/changeset/DifferentialChangesetParser.php
View file

@ -1355,7 +1355,7 @@ final class DifferentialChangesetParser {
if ($this->old[$ii]['type'] == '\\') {
$o_text = $this->old[$ii]['text'];
$o_attr = ' class="comment"';
} elseif (empty($this->new[$ii])) {
} else if (empty($this->new[$ii])) {
$o_attr = ' class="old old-full"';
} else {
$o_attr = ' class="old"';
@ -1389,7 +1389,7 @@ final class DifferentialChangesetParser {
if ($this->new[$ii]['type'] == '\\') {
$n_text = $this->new[$ii]['text'];
$n_attr = ' class="comment"';
} elseif (empty($this->old[$ii])) {
} else if (empty($this->old[$ii])) {
$n_attr = ' class="new new-full"';
} else {
$n_attr = ' class="new"';

2
src/applications/differential/view/revisioncommentlist/DifferentialRevisionCommentListView.php
View file

@ -89,7 +89,7 @@ final class DifferentialRevisionCommentListView extends AphrontView {
$view->setVersusDiffID($this->versusDiffID);
if ($comment->getAction() == DifferentialAction::ACTION_SUMMARIZE) {
$view->setAnchorName('summary');
} elseif ($comment->getAction() == DifferentialAction::ACTION_TESTPLAN) {
} else if ($comment->getAction() == DifferentialAction::ACTION_TESTPLAN) {
$view->setAnchorName('test-plan');
} else {
$view->setAnchorName('comment-'.$num);

6
src/applications/search/controller/search/PhabricatorSearchController.php
View file

@ -239,7 +239,7 @@ final class PhabricatorSearchController
->loadOneWhere('callsign = %s', $match[1]);
if ($match[2] == '') {
$jump = $repository;
} elseif ($repository) {
} else if ($repository) {
$jump = id(new PhabricatorRepositoryCommit())->loadOneWhere(
'repositoryID = %d AND commitIdentifier = %s',
$repository->getID(),
@ -255,9 +255,9 @@ final class PhabricatorSearchController
}
}
}
} elseif (preg_match('/^d(\d+)$/i', $query_str, $match)) {
} else if (preg_match('/^d(\d+)$/i', $query_str, $match)) {
$jump = id(new DifferentialRevision())->load($match[1]);
} elseif (preg_match('/^t(\d+)$/i', $query_str, $match)) {
} else if (preg_match('/^t(\d+)$/i', $query_str, $match)) {
$jump = id(new ManiphestTask())->load($match[1]);
}
if ($jump) {

2
src/infrastructure/setup/PhabricatorSetup.php
View file

@ -745,7 +745,7 @@ final class PhabricatorSetup {
if (!$r->isSubclassOf($instanceof)) {
throw new Exception(
"Config setting '$key' must be an instance of '$instanceof'.");
} elseif (!$r->isInstantiable()) {
} else if (!$r->isInstantiable()) {
throw new Exception("Config setting '$key' must be instantiable.");
}
} catch (Exception $ex) {