Move Passphrase to SearchField

Summary: Prepares for bringing spaces and a new object policy here.

Test Plan: Used all search controls dozens of times.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D13384

src/applications/passphrase/query/PassphraseCredentialQuery.php

@@ -53,19 +53,12 @@ final class PassphraseCredentialQuery
     return $this;
   }
 
+  public function newResultObject() {
+    return new PassphraseCredential();
+  }
+
   protected function loadPage() {
-    $table = new PassphraseCredential();
+    return $this->loadStandardPage($this->newResultObject());
-    $conn_r = $table->establishConnection('r');
-
-    $rows = queryfx_all(
-      $conn_r,
-      'SELECT * FROM %T %Q %Q %Q',
-      $table->getTableName(),
-      $this->buildWhereClause($conn_r),
-      $this->buildOrderClause($conn_r),
-      $this->buildLimitClause($conn_r));
-
-    return $table->loadAllFromArray($rows);
   }
 
   protected function willFilterPage(array $page) {
@@ -99,61 +92,59 @@ final class PassphraseCredentialQuery
     return $page;
   }
 
-  protected function buildWhereClause(AphrontDatabaseConnection $conn_r) {
+  protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
-    $where = array();
+    $where = parent::buildWhereClauseParts($conn);
 
-    $where[] = $this->buildPagingClause($conn_r);
+    if ($this->ids !== null) {
-
-    if ($this->ids) {
       $where[] = qsprintf(
-        $conn_r,
+        $conn,
         'id IN (%Ld)',
         $this->ids);
     }
 
-    if ($this->phids) {
+    if ($this->phids !== null) {
       $where[] = qsprintf(
-        $conn_r,
+        $conn,
         'phid IN (%Ls)',
         $this->phids);
     }
 
-    if ($this->credentialTypes) {
+    if ($this->credentialTypes !== null) {
       $where[] = qsprintf(
-        $conn_r,
+        $conn,
         'credentialType in (%Ls)',
         $this->credentialTypes);
     }
 
-    if ($this->providesTypes) {
+    if ($this->providesTypes !== null) {
       $where[] = qsprintf(
-        $conn_r,
+        $conn,
         'providesType IN (%Ls)',
         $this->providesTypes);
     }
 
     if ($this->isDestroyed !== null) {
       $where[] = qsprintf(
-        $conn_r,
+        $conn,
         'isDestroyed = %d',
         (int)$this->isDestroyed);
     }
 
     if ($this->allowConduit !== null) {
       $where[] = qsprintf(
-        $conn_r,
+        $conn,
         'allowConduit = %d',
         (int)$this->allowConduit);
     }
 
     if (strlen($this->nameContains)) {
       $where[] = qsprintf(
-        $conn_r,
+        $conn,
-        'name LIKE %~',
+        'LOWER(name) LIKE %~',
-        $this->nameContains);
+        phutil_utf8_strtolower($this->nameContains));
     }
 
-    return $this->formatWhereClause($where);
+    return $where;
   }
 
   public function getQueryApplicationClass() {

src/applications/passphrase/query/PassphraseCredentialSearchEngine.php

@@ -11,58 +11,39 @@ final class PassphraseCredentialSearchEngine
     return 'PhabricatorPassphraseApplication';
   }
 
-  public function buildSavedQueryFromRequest(AphrontRequest $request) {
+  public function newQuery() {
-    $saved = new PhabricatorSavedQuery();
+    return new PassphraseCredentialQuery();
-
-    $saved->setParameter(
-      'isDestroyed',
-      $this->readBoolFromRequest($request, 'isDestroyed'));
-    $saved->setParameter('name', $request->getStr('name'));
-
-    return $saved;
   }
 
-  public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) {
+  protected function buildCustomSearchFields() {
-    $query = id(new PassphraseCredentialQuery());
+    return array(
-
+      id(new PhabricatorSearchThreeStateField())
-    $destroyed = $saved->getParameter('isDestroyed');
+        ->setLabel(pht('Status'))
-    if ($destroyed !== null) {
+        ->setKey('isDestroyed')
-      $query->withIsDestroyed($destroyed);
+        ->setOptions(
+          pht('Show All'),
+          pht('Show Only Destroyed Credentials'),
+          pht('Show Only Active Credentials')),
+      id(new PhabricatorSearchTextField())
+        ->setLabel(pht('Name Contains'))
+        ->setKey('name'),
+    );
   }
 
-    $name = $saved->getParameter('name');
+  protected function buildQueryFromParameters(array $map) {
-    if (strlen($name)) {
+    $query = $this->newQuery();
-      $query->withNameContains($name);
+
+    if ($map['isDestroyed'] !== null) {
+      $query->withIsDestroyed($map['isDestroyed']);
+    }
+
+    if (strlen($map['name'])) {
+      $query->withNameContains($map['name']);
     }
 
     return $query;
   }
 
-  public function buildSearchForm(
-    AphrontFormView $form,
-    PhabricatorSavedQuery $saved_query) {
-
-    $name = $saved_query->getParameter('name');
-
-    $form
-      ->appendChild(
-      id(new AphrontFormSelectControl())
-        ->setName('isDestroyed')
-        ->setLabel(pht('Status'))
-        ->setValue($this->getBoolFromQuery($saved_query, 'isDestroyed'))
-        ->setOptions(
-          array(
-            '' => pht('Show All Credentials'),
-            'false' => pht('Show Only Active Credentials'),
-            'true' => pht('Show Only Destroyed Credentials'),
-          )))
-      ->appendChild(
-        id(new AphrontFormTextControl())
-          ->setName('name')
-          ->setLabel(pht('Name Contains'))
-          ->setValue($name));
-  }
-
   protected function getURI($path) {
     return '/passphrase/'.$path;
   }