revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-04-10 03:18:41 +02:00
Code Issues Releases Wiki Activity

Fix exception when viewing Owners packages owned by projects you are a member of

Browse source 
Summary: Fixes T3188. See that task for details.

Test Plan: Viewed packages with and without project membership; no more exception.

Reviewers: btrahan, chad

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3188

Differential Revision: https://secure.phabricator.com/D5918
This commit is contained in:
epriestley 2013-05-13 09:59:42 -07:00
parent df6a66f577
commit bc6d785b51
1 changed files with 11 additions and 7 deletions

18
src/applications/owners/controller/PhabricatorOwnersListController.php
View file

@ -115,13 +115,17 @@ final class PhabricatorOwnersListController
->withStatus(PhabricatorProjectQuery::STATUS_ANY) ->withStatus(PhabricatorProjectQuery::STATUS_ANY)
->execute(); ->execute();
$owner_phids = mpull($projects, 'getPHID'); $owner_phids = mpull($projects, 'getPHID');
$data = queryfx_all( if ($owner_phids) {
$package->establishConnection('r'), $data = queryfx_all(
'SELECT p.* FROM %T p JOIN %T o ON p.id = o.packageID $package->establishConnection('r'),
WHERE o.userPHID IN (%Ls) GROUP BY p.id', 'SELECT p.* FROM %T p JOIN %T o ON p.id = o.packageID
$package->getTableName(), WHERE o.userPHID IN (%Ls) GROUP BY p.id',
$owner->getTableName(), $package->getTableName(),
$owner_phids); $owner->getTableName(),
$owner_phids);
} else {
$data = array();
}
$packages = $package->loadAllFromArray($data); $packages = $package->loadAllFromArray($data);
$header = 'Owned Packages'; $header = 'Owned Packages';