1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-30 02:32:42 +01:00

Notifications - add a "Clear All Notifications" link to dropdown

Summary: Fixes T2576. Also hyperlinks "Notifications" and "Messages" for easier quick navigation to those areas. Maybe we could get rid of the "See All X" UI at the bottom and use these links?

Test Plan: cleared all notifications from new UI - it worked! observed new linked "Notifications" and "Messages" headers

Reviewers: chad, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T2576

Differential Revision: https://secure.phabricator.com/D8894
This commit is contained in:
Bob Trahan 2014-04-29 10:43:38 -07:00
parent 3a0694543d
commit bcdef099c2
4 changed files with 35 additions and 8 deletions

View file

@ -7,7 +7,7 @@
return array( return array(
'names' => 'names' =>
array( array(
'core.pkg.css' => 'a762d94d', 'core.pkg.css' => 'b7ba02ba',
'core.pkg.js' => '417722ff', 'core.pkg.js' => '417722ff',
'darkconsole.pkg.js' => 'ca8671ce', 'darkconsole.pkg.js' => 'ca8671ce',
'differential.pkg.css' => '8a064eb7', 'differential.pkg.css' => '8a064eb7',
@ -38,7 +38,7 @@ return array(
'rsrc/css/aphront/typeahead.css' => '271456a1', 'rsrc/css/aphront/typeahead.css' => '271456a1',
'rsrc/css/application/auth/auth.css' => '1e655982', 'rsrc/css/application/auth/auth.css' => '1e655982',
'rsrc/css/application/base/main-menu-view.css' => '0a599177', 'rsrc/css/application/base/main-menu-view.css' => '0a599177',
'rsrc/css/application/base/notification-menu.css' => 'fc9a363c', 'rsrc/css/application/base/notification-menu.css' => '99ffef72',
'rsrc/css/application/base/phabricator-application-launch-view.css' => 'd290ba21', 'rsrc/css/application/base/phabricator-application-launch-view.css' => 'd290ba21',
'rsrc/css/application/base/standard-page-view.css' => '517cdfb1', 'rsrc/css/application/base/standard-page-view.css' => '517cdfb1',
'rsrc/css/application/chatlog/chatlog.css' => '852140ff', 'rsrc/css/application/chatlog/chatlog.css' => '852140ff',
@ -87,7 +87,7 @@ return array(
'rsrc/css/application/phrequent/phrequent.css' => 'ffc185ad', 'rsrc/css/application/phrequent/phrequent.css' => 'ffc185ad',
'rsrc/css/application/phriction/phriction-document-css.css' => '7d7f0071', 'rsrc/css/application/phriction/phriction-document-css.css' => '7d7f0071',
'rsrc/css/application/policy/policy-edit.css' => '05cca26a', 'rsrc/css/application/policy/policy-edit.css' => '05cca26a',
'rsrc/css/application/policy/policy-transaction-detail.css' => '21b7daba', 'rsrc/css/application/policy/policy-transaction-detail.css' => '82100a43',
'rsrc/css/application/policy/policy.css' => '957ea14c', 'rsrc/css/application/policy/policy.css' => '957ea14c',
'rsrc/css/application/ponder/comments.css' => '6cdccea7', 'rsrc/css/application/ponder/comments.css' => '6cdccea7',
'rsrc/css/application/ponder/feed.css' => 'e62615b6', 'rsrc/css/application/ponder/feed.css' => 'e62615b6',
@ -705,7 +705,7 @@ return array(
'phabricator-nav-view-css' => '80e60fc1', 'phabricator-nav-view-css' => '80e60fc1',
'phabricator-notification' => '0c6946e7', 'phabricator-notification' => '0c6946e7',
'phabricator-notification-css' => 'ef2c9b34', 'phabricator-notification-css' => 'ef2c9b34',
'phabricator-notification-menu-css' => 'fc9a363c', 'phabricator-notification-menu-css' => '99ffef72',
'phabricator-object-selector-css' => '029a133d', 'phabricator-object-selector-css' => '029a133d',
'phabricator-phtize' => 'd254d646', 'phabricator-phtize' => 'd254d646',
'phabricator-prefab' => '0326e5d0', 'phabricator-prefab' => '0326e5d0',
@ -772,7 +772,7 @@ return array(
'phui-workpanel-view-css' => '97b69459', 'phui-workpanel-view-css' => '97b69459',
'policy-css' => '957ea14c', 'policy-css' => '957ea14c',
'policy-edit-css' => '05cca26a', 'policy-edit-css' => '05cca26a',
'policy-transaction-detail-css' => '21b7daba', 'policy-transaction-detail-css' => '82100a43',
'ponder-comment-table-css' => '6cdccea7', 'ponder-comment-table-css' => '6cdccea7',
'ponder-feed-view-css' => 'e62615b6', 'ponder-feed-view-css' => 'e62615b6',
'ponder-post-css' => 'ebab8a70', 'ponder-post-css' => 'ebab8a70',

View file

@ -81,7 +81,12 @@ final class ConpherenceNotificationPanelController
'<div class="phabricator-notification-header">%s</div>'. '<div class="phabricator-notification-header">%s</div>'.
'%s'. '%s'.
'<div class="phabricator-notification-view-all">%s</div>', '<div class="phabricator-notification-view-all">%s</div>',
pht('Messages'), phutil_tag(
'a',
array(
'href' => '/conpherence/',
),
pht('Messages')),
$content, $content,
phutil_tag( phutil_tag(
'a', 'a',

View file

@ -26,10 +26,23 @@ final class PhabricatorNotificationPanelController
} }
$content = hsprintf( $content = hsprintf(
'<div class="phabricator-notification-header">%s</div>'. '<div class="phabricator-notification-header">%s %s</div>'.
'%s'. '%s'.
'<div class="phabricator-notification-view-all">%s</div>', '<div class="phabricator-notification-view-all">%s</div>',
pht('Notifications'), phutil_tag(
'a',
array(
'href' => '/notification/',
),
pht('Notifications')),
javelin_tag(
'a',
array(
'sigil' => 'workflow',
'href' => '/notification/clear/',
'class' => 'phabricator-notification-clear-all'
),
pht('Clear All Notifications')),
$content, $content,
phutil_tag( phutil_tag(
'a', 'a',

View file

@ -74,6 +74,15 @@
border-bottom: 1px solid #e9e9e9; border-bottom: 1px solid #e9e9e9;
} }
.phabricator-notification-header a {
color: {$darkgreytext};
}
.phabricator-notification-header .phabricator-notification-clear-all {
color: #18559D;
float: right;
}
.phabricator-notification-view-all { .phabricator-notification-view-all {
text-align: center; text-align: center;
font-weight: bold; font-weight: bold;