Remove CHECKREQUEST event

Summary: Fixes T8749.

Test Plan: `grep`

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8749

Differential Revision: https://secure.phabricator.com/D13546

src/applications/base/controller/PhabricatorController.php

@@ -157,19 +157,6 @@ abstract class PhabricatorController extends AphrontController {
       }
     }
 
-    $event = new PhabricatorEvent(
-      PhabricatorEventType::TYPE_CONTROLLER_CHECKREQUEST,
-      array(
-        'request' => $request,
-        'controller' => $this,
-      ));
-    $event->setUser($user);
-    PhutilEventEngine::dispatchEvent($event);
-    $checker_controller = $event->getValue('controller');
-    if ($checker_controller != $this) {
-      return $this->delegateToController($checker_controller);
-    }
-
     $auth_class = 'PhabricatorAuthApplication';
     $auth_application = PhabricatorApplication::getByClass($auth_class);
 

src/docs/user/userguide/events.diviner

@@ -130,22 +130,6 @@ fields to, e.g., edit revision titles. Data available on this event:
   - `specification` Parameters that will be used to invoke the
     `differential.createrevision` Conduit call.
 
-== Controller: Check Request ==
-
-The constant for this event is
-`PhabricatorEventType::TYPE_CONTROLLER_CHECKREQUEST`.
-
-This event is dispatched when controller is about to begin execution. It is
-meant for checking if the user is allowed to use the application at the moment.
-It can check if the user has performed too many operations recently, if his IP
-address is allowed or if the servers are overloaded to process the request.
-Data available on this event:
-
-- `request` Object of class @{class:AphrontRequest}.
-- `controller` Class name of the current controller.
-
-You can delegate the execution to another controller by modifying `controller`.
-
 == Maniphest: Will Edit Task ==
 
 The constant for this event is

src/infrastructure/events/constant/PhabricatorEventType.php

@@ -6,8 +6,6 @@
  */
 final class PhabricatorEventType extends PhutilEventType {
 
-  const TYPE_CONTROLLER_CHECKREQUEST        = 'controller.checkRequest';
-
   const TYPE_MANIPHEST_WILLEDITTASK         = 'maniphest.willEditTask';
   const TYPE_MANIPHEST_DIDEDITTASK          = 'maniphest.didEditTask';