From bd12a2b839b3887ddfa3752095b32fc2cc07a23f Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Wed, 7 Dec 2011 06:58:16 -0800
Subject: [PATCH] Fix a final (?) task field issue which slipped through the
 cracks

Summary:
Derped this one up; while my testing was successful in preventing runaway
attaching I missed the bit where it doesn't actually work.

This resolves the "Unknown Object" link seen on T661.

Test Plan:
  - Created two new revisions, each attached to a local task.
  - Verified that they attached additively, Maniphest and Differential were
linked to the right places, and nothign else bad happened.

Reviewers: btrahan, fratrik

Reviewed By: fratrik

CC: aran, fratrik, btrahan

Differential Revision: 1181
---
 .../DifferentialManiphestTasksFieldSpecification.php            | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/applications/differential/field/specification/maniphesttasks/DifferentialManiphestTasksFieldSpecification.php b/src/applications/differential/field/specification/maniphesttasks/DifferentialManiphestTasksFieldSpecification.php
index 345520e4ca..45228ef94d 100644
--- a/src/applications/differential/field/specification/maniphesttasks/DifferentialManiphestTasksFieldSpecification.php
+++ b/src/applications/differential/field/specification/maniphesttasks/DifferentialManiphestTasksFieldSpecification.php
@@ -86,7 +86,7 @@ final class DifferentialManiphestTasksFieldSpecification
       if (empty($new[$attach_type])) {
         $new[$attach_type] = array();
       }
-      $new[$attach_type][$revision->getPHID] = array();
+      $new[$attach_type][$revision->getPHID()] = array();
 
       $transaction->setNewValue($new);
       $maniphest_editor->applyTransactions($task, array($transaction));