From bd1bc6d71a4df996b1b6316186ad12a3a63e9b78 Mon Sep 17 00:00:00 2001 From: Bob Trahan Date: Thu, 8 Nov 2012 12:21:50 -0800 Subject: [PATCH] fix error where blank email addresses were sneaking in the stack Summary: array_filter to the rescue Test Plan: mostly lots of reasoning (as opposed to making a fake user with a blank email address to reproduce) Reviewers: epriestley, chad Reviewed By: chad CC: aran, Korvin Maniphest Tasks: T2052 Differential Revision: https://secure.phabricator.com/D3927 --- .../metamta/storage/PhabricatorMetaMTAReceivedMail.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php b/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php index d8bdcaedc6..85fba7c22a 100644 --- a/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php +++ b/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php @@ -356,7 +356,7 @@ final class PhabricatorMetaMTAReceivedMail extends PhabricatorMetaMTADAO { foreach (explode(',', $addresses) as $address) { $raw_addresses[] = $this->getRawEmailAddress($address); } - return $raw_addresses; + return array_filter($raw_addresses); } private function lookupPublicUser() {