From bda2c5784dc0ed840aea055600737592dab3a782 Mon Sep 17 00:00:00 2001 From: Bob Trahan Date: Thu, 2 May 2013 15:23:55 -0700 Subject: [PATCH] Conpherence - fix no conpherences fatal Summary: Fixes T3087. I guess I didn't load up the actual Conpherence UI last time I was in here with my 'noconpherences' user. :/ Test Plan: noconpherences user loaded /conpherence/ with no error Reviewers: epriestley, chad Reviewed By: chad CC: aran, Korvin Maniphest Tasks: T3087 Differential Revision: https://secure.phabricator.com/D5815 --- .../conpherence/controller/ConpherenceListController.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/applications/conpherence/controller/ConpherenceListController.php b/src/applications/conpherence/controller/ConpherenceListController.php index 5de32de748..9ff71e83f9 100644 --- a/src/applications/conpherence/controller/ConpherenceListController.php +++ b/src/applications/conpherence/controller/ConpherenceListController.php @@ -228,16 +228,17 @@ final class ConpherenceListController private function loadConpherenceThreadData($participation) { $user = $this->getRequest()->getUser(); $conpherence_phids = array_keys($participation); + $conpherences = array(); if ($conpherence_phids) { $conpherences = id(new ConpherenceThreadQuery()) ->setViewer($user) ->withPHIDs($conpherence_phids) ->needParticipantCache(true) ->execute(); - } - // this will re-sort by participation data - $conpherences = array_select_keys($conpherences, $conpherence_phids); + // this will re-sort by participation data + $conpherences = array_select_keys($conpherences, $conpherence_phids); + } return $conpherences; }