revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 01:02:42 +01:00
Code Issues Releases Wiki Activity

Fix Ponder Exception, spacing

Browse source 
Summary: Evidently I only tested adding a question, not an answer. Properly set the getter. Also, fixed some header spacing.

Test Plan: Add a question, add an answer. See everything work, proper spacing.

Reviewers: epriestley, avivey

Reviewed By: avivey

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15341
This commit is contained in:
Chad Little 2016-02-23 20:30:43 -08:00
parent 03d6e7f1b6
commit be0e84a81a
4 changed files with 15 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
resources/celerity/map.php
View file

@ -92,7 +92,7 @@ return array(
'rsrc/css/application/policy/policy-edit.css' => '815c66f7', 'rsrc/css/application/policy/policy-edit.css' => '815c66f7',
'rsrc/css/application/policy/policy-transaction-detail.css' => '82100a43', 'rsrc/css/application/policy/policy-transaction-detail.css' => '82100a43',
'rsrc/css/application/policy/policy.css' => '957ea14c', 'rsrc/css/application/policy/policy.css' => '957ea14c',
'rsrc/css/application/ponder/ponder-view.css' => 'fdd4629b', 'rsrc/css/application/ponder/ponder-view.css' => '212495e0',
'rsrc/css/application/project/project-card-view.css' => '9418c97d', 'rsrc/css/application/project/project-card-view.css' => '9418c97d',
'rsrc/css/application/project/project-view.css' => '298b7c5b', 'rsrc/css/application/project/project-view.css' => '298b7c5b',
'rsrc/css/application/releeph/releeph-core.css' => '9b3c5733', 'rsrc/css/application/releeph/releeph-core.css' => '9b3c5733',
@ -855,7 +855,7 @@ return array(
'policy-css' => '957ea14c', 'policy-css' => '957ea14c',
'policy-edit-css' => '815c66f7', 'policy-edit-css' => '815c66f7',
'policy-transaction-detail-css' => '82100a43', 'policy-transaction-detail-css' => '82100a43',
'ponder-view-css' => 'fdd4629b', 'ponder-view-css' => '212495e0',
'project-card-view-css' => '9418c97d', 'project-card-view-css' => '9418c97d',
'project-view-css' => '298b7c5b', 'project-view-css' => '298b7c5b',
'releeph-core' => '9b3c5733', 'releeph-core' => '9b3c5733',

7
src/applications/ponder/controller/PonderQuestionViewController.php
View file

@ -322,7 +322,12 @@ final class PonderQuestionViewController extends PonderController {
$header = id(new PHUIHeaderView()) $header = id(new PHUIHeaderView())
->setHeader('Answers'); ->setHeader('Answers');
return array($header, $view);
return id(new PHUIBoxView())
->addClass('ponder-answer-section')
->appendChild($header)
->appendChild($view);
} }
return null; return null;

3
src/applications/ponder/storage/PonderAnswer.php
View file

@ -17,6 +17,7 @@ final class PonderAnswer extends PonderDAO
protected $content; protected $content;
protected $mailKey; protected $mailKey;
protected $status; protected $status;
protected $voteCount;
private $question = self::ATTACHABLE; private $question = self::ATTACHABLE;
private $comments; private $comments;
@ -34,7 +35,7 @@ final class PonderAnswer extends PonderDAO
->setContent('') ->setContent('')
->attachQuestion($question) ->attachQuestion($question)
->setAuthorPHID($actor->getPHID()) ->setAuthorPHID($actor->getPHID())
->setVoteCount('0') ->setVoteCount(0)
->setStatus(PonderAnswerStatus::ANSWER_STATUS_VISIBLE); ->setStatus(PonderAnswerStatus::ANSWER_STATUS_VISIBLE);
} }

6
webroot/rsrc/css/application/ponder/ponder-view.css
View file

@ -169,7 +169,7 @@
} }
.ponder-answer-view .ponder-footer-view { .ponder-answer-view .ponder-footer-view {
margin-top: 24px; margin-top: 16px;
border-top: 1px solid rgba({$alphagrey}, .15); border-top: 1px solid rgba({$alphagrey}, .15);
border-bottom: none; border-bottom: none;
} }
@ -186,6 +186,10 @@ body .phui-main-column .ponder-question-content .ponder-answer-view
display: inline-block; display: inline-block;
} }
.ponder-answer-section {
margin-top: 32px;
}
.ponder-add-answer-header { .ponder-add-answer-header {
margin-top: 64px; margin-top: 64px;
} }