revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00
Code Issues Releases Wiki Activity

Fix a cursor paging issue in Conduit call logs

Browse source 
Summary: Fixes T13423. The "Query" class for conduit call logs is missing a "withIDs()" method.

Test Plan: Paged through Conduit call logs.

Maniphest Tasks: T13423

Differential Revision: https://secure.phabricator.com/D20823
This commit is contained in:
epriestley 2019-09-24 08:33:18 -07:00
parent 09d86c2d20
commit be2a0f8733
1 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/applications/conduit/query/PhabricatorConduitLogQuery.php
View file

@ -3,12 +3,18 @@
final class PhabricatorConduitLogQuery final class PhabricatorConduitLogQuery
extends PhabricatorCursorPagedPolicyAwareQuery { extends PhabricatorCursorPagedPolicyAwareQuery {
private $ids;
private $callerPHIDs; private $callerPHIDs;
private $methods; private $methods;
private $methodStatuses; private $methodStatuses;
private $epochMin; private $epochMin;
private $epochMax; private $epochMax;
public function withIDs(array $ids) {
$this->ids = $ids;
return $this;
}
public function withCallerPHIDs(array $phids) { public function withCallerPHIDs(array $phids) {
$this->callerPHIDs = $phids; $this->callerPHIDs = $phids;
return $this; return $this;
@ -41,6 +47,13 @@ final class PhabricatorConduitLogQuery
protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
$where = parent::buildWhereClauseParts($conn); $where = parent::buildWhereClauseParts($conn);
if ($this->ids !== null) {
$where[] = qsprintf(
$conn,
'id IN (%Ld)',
$this->ids);
}
if ($this->callerPHIDs !== null) { if ($this->callerPHIDs !== null) {
$where[] = qsprintf( $where[] = qsprintf(
$conn, $conn,