revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 06:20:56 +01:00
Code Issues Releases Wiki Activity

Remove logic which hides commit names in commit table when they're the same as previous commit names

Browse source 
Summary:
See discussion in T2832. In particular, this is pretty confusing:

{F38674}

The confusion created in situations like this is much worse than the tiny benefit in parseability the UI rule provides. We'll probably rewrite this table in terms of ObjectListView anyway.

Fixes T2832.

Test Plan: Looked at Audit list.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2832

Differential Revision: https://secure.phabricator.com/D5610
This commit is contained in:
epriestley 2013-04-07 15:50:21 -07:00
parent d98401833b
commit be586de965
1 changed files with 6 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/applications/audit/view/PhabricatorAuditListView.php
View file

@ -110,23 +110,17 @@ final class PhabricatorAuditListView extends AphrontView {
public function render() { public function render() {
$rowc = array(); $rowc = array();
$last = null;
$rows = array(); $rows = array();
foreach ($this->audits as $audit) { foreach ($this->audits as $audit) {
$commit_phid = $audit->getCommitPHID(); $commit_phid = $audit->getCommitPHID();
$committed = null; $committed = null;
if ($last == $commit_phid) {
$commit_name = null;
$commit_desc = null;
} else {
$commit_name = $this->getHandle($commit_phid)->renderLink(); $commit_name = $this->getHandle($commit_phid)->renderLink();
$commit_desc = $this->getCommitDescription($commit_phid); $commit_desc = $this->getCommitDescription($commit_phid);
$commit = idx($this->commits, $commit_phid); $commit = idx($this->commits, $commit_phid);
if ($commit && $this->user) { if ($commit && $this->user) {
$committed = phabricator_datetime($commit->getEpoch(), $this->user); $committed = phabricator_datetime($commit->getEpoch(), $this->user);
} }
$last = $commit_phid;
}
$reasons = $audit->getAuditReasons(); $reasons = $audit->getAuditReasons();
$reasons = phutil_implode_html(phutil_tag('br'), $reasons); $reasons = phutil_implode_html(phutil_tag('br'), $reasons);