From bee69f9ce209b9333ec20442d7e09a18117c0a48 Mon Sep 17 00:00:00 2001 From: Bill Fumerola Date: Fri, 23 Mar 2012 16:28:42 -0700 Subject: [PATCH] do not re-use output when an exception occurs Summary: $stdout from the previous run would be reused if an exception occurred Test Plan: that's a negative, ghostrider. Reviewers: epriestley, jungejason Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D2008 --- .../diffusion/query/diff/svn/DiffusionSvnDiffQuery.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/applications/diffusion/query/diff/svn/DiffusionSvnDiffQuery.php b/src/applications/diffusion/query/diff/svn/DiffusionSvnDiffQuery.php index a0df4158ba..e56be33a90 100644 --- a/src/applications/diffusion/query/diff/svn/DiffusionSvnDiffQuery.php +++ b/src/applications/diffusion/query/diff/svn/DiffusionSvnDiffQuery.php @@ -99,6 +99,7 @@ final class DiffusionSvnDiffQuery extends DiffusionDiffQuery { $futures = array_filter($futures); foreach (Futures($futures) as $key => $future) { + $stdout = ''; try { list($stdout) = $future->resolvex(); } catch (CommandException $e) {