1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-18 12:52:42 +01:00

Move "Calendar" above "Badges" on user profiles

Summary:
Ref T11809. As we move toward unprototyping, this panel is probably more relevant/dynamic/interesting more often than the badges panel, I think?

Particularly, I want to make the red dots a little easier to understand, and I think putting this above the fold will help aid discovery (red dot -> click -> see red dot -> see "away until ..." -> see calendar -> "oh they're at a meeting"?).

This is entirely a product/subjective thing so I'm fine with not doing it or using a different order.

I think there's maybe even an argument for putting this above "Projects", but "Projects" feels more core to me, at least for now.

Test Plan: Viewed a user profile, saw "Calendar" above "Badges".

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11809

Differential Revision: https://secure.phabricator.com/D16790
This commit is contained in:
epriestley 2016-11-02 09:50:26 -07:00
parent 713f8fb373
commit bf0004744b

View file

@ -58,8 +58,8 @@ final class PhabricatorPeopleProfileViewController
->appendChild($feed); ->appendChild($feed);
$projects = $this->buildProjectsView($user); $projects = $this->buildProjectsView($user);
$badges = $this->buildBadgesView($user);
$calendar = $this->buildCalendarDayView($user); $calendar = $this->buildCalendarDayView($user);
$badges = $this->buildBadgesView($user);
require_celerity_resource('project-view-css'); require_celerity_resource('project-view-css');
$home = id(new PHUITwoColumnView()) $home = id(new PHUITwoColumnView())
@ -73,8 +73,8 @@ final class PhabricatorPeopleProfileViewController
->setSideColumn( ->setSideColumn(
array( array(
$projects, $projects,
$badges,
$calendar, $calendar,
$badges,
)); ));
$nav = $this->getProfileMenu(); $nav = $this->getProfileMenu();