Remove "disabled" look to subprojects/workboard nav items

Summary: Fixes T12330. Minor UI nit, since we use "disabled" to usually mean "no permission". Makes these links always normal looking.

Test Plan: Review a new project in sandbox.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T12330

Differential Revision: https://secure.phabricator.com/D17436

src/applications/project/menuitem/PhabricatorProjectSubprojectsProfileMenuItem.php

@@ -47,10 +47,6 @@ final class PhabricatorProjectSubprojectsProfileMenuItem
     PhabricatorProfileMenuItemConfiguration $config) {
 
     $project = $config->getProfileObject();
-
-    $has_children = ($project->getHasSubprojects()) ||
-                    ($project->getHasMilestones());
-
     $id = $project->getID();
 
     $name = $this->getDisplayName($config);
@@ -60,7 +56,6 @@ final class PhabricatorProjectSubprojectsProfileMenuItem
     $item = $this->newItem()
       ->setHref($href)
       ->setName($name)
-      ->setDisabled(!$has_children)
       ->setIcon($icon);
 
     return array(

src/applications/project/menuitem/PhabricatorProjectWorkboardProfileMenuItem.php

@@ -56,8 +56,6 @@ final class PhabricatorProjectWorkboardProfileMenuItem
     PhabricatorProfileMenuItemConfiguration $config) {
     $project = $config->getProfileObject();
 
-    $has_workboard = $project->getHasWorkboard();
-
     $id = $project->getID();
     $href = "/project/board/{$id}/";
     $name = $this->getDisplayName($config);
@@ -65,7 +63,6 @@ final class PhabricatorProjectWorkboardProfileMenuItem
     $item = $this->newItem()
       ->setHref($href)
       ->setName($name)
-      ->setDisabled(!$has_workboard)
       ->setIcon('fa-columns');
 
     return array(