Reduce application search engine results list for Dashboards

Summary: Ref T10390. Simplifies dropdown by rolling out canUseInPanel in useless panels

Test Plan: Add a query panel, see less options.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T10390

Differential Revision: https://secure.phabricator.com/D17341

src/applications/audit/query/PhabricatorCommitSearchEngine.php

@@ -4,7 +4,7 @@ final class PhabricatorCommitSearchEngine
   extends PhabricatorApplicationSearchEngine {
 
   public function getResultTypeDescription() {
-    return pht('Commits');
+    return pht('Diffusion Commits');
   }
 
   public function getApplicationClassName() {

src/applications/auth/query/PhabricatorAuthInviteSearchEngine.php

@@ -4,13 +4,17 @@ final class PhabricatorAuthInviteSearchEngine
   extends PhabricatorApplicationSearchEngine {
 
   public function getResultTypeDescription() {
-    return pht('Email Invites');
+    return pht('Auth Email Invites');
   }
 
   public function getApplicationClassName() {
     return 'PhabricatorAuthApplication';
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   public function buildSavedQueryFromRequest(AphrontRequest $request) {
     $saved = new PhabricatorSavedQuery();
 

src/applications/badges/query/PhabricatorBadgesSearchEngine.php

@@ -4,7 +4,7 @@ final class PhabricatorBadgesSearchEngine
   extends PhabricatorApplicationSearchEngine {
 
   public function getResultTypeDescription() {
-    return pht('Badge');
+    return pht('Badges');
   }
 
   public function getApplicationClassName() {

src/applications/calendar/query/PhabricatorCalendarExportSearchEngine.php

@@ -11,6 +11,10 @@ final class PhabricatorCalendarExportSearchEngine
     return 'PhabricatorCalendarApplication';
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   public function newQuery() {
     $viewer = $this->requireViewer();
 

src/applications/calendar/query/PhabricatorCalendarImportLogSearchEngine.php

@@ -11,6 +11,10 @@ final class PhabricatorCalendarImportLogSearchEngine
     return 'PhabricatorCalendarApplication';
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   public function newQuery() {
     return new PhabricatorCalendarImportLogQuery();
   }

src/applications/calendar/query/PhabricatorCalendarImportSearchEngine.php

@@ -11,6 +11,10 @@ final class PhabricatorCalendarImportSearchEngine
     return 'PhabricatorCalendarApplication';
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   public function newQuery() {
     return new PhabricatorCalendarImportQuery();
   }

src/applications/conduit/query/PhabricatorConduitLogSearchEngine.php

@@ -11,6 +11,10 @@ final class PhabricatorConduitLogSearchEngine
     return 'PhabricatorConduitApplication';
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   public function newQuery() {
     return new PhabricatorConduitLogQuery();
   }

src/applications/conduit/query/PhabricatorConduitSearchEngine.php

@@ -11,6 +11,10 @@ final class PhabricatorConduitSearchEngine
     return 'PhabricatorConduitApplication';
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   public function getPageSize(PhabricatorSavedQuery $saved) {
     return PHP_INT_MAX - 1;
   }

src/applications/conpherence/query/ConpherenceThreadSearchEngine.php

@@ -4,7 +4,7 @@ final class ConpherenceThreadSearchEngine
   extends PhabricatorApplicationSearchEngine {
 
   public function getResultTypeDescription() {
-    return pht('Rooms');
+    return pht('Conpherence Rooms');
   }
 
   public function getApplicationClassName() {

src/applications/dashboard/query/PhabricatorDashboardPanelSearchEngine.php

@@ -15,6 +15,10 @@ final class PhabricatorDashboardPanelSearchEngine
     return new PhabricatorDashboardPanelQuery();
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   protected function buildQueryFromParameters(array $map) {
     $query = $this->newQuery();
     if ($map['status']) {

src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php

@@ -16,6 +16,10 @@ final class PhabricatorDashboardSearchEngine
       ->needPanels(true);
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   protected function buildCustomSearchFields() {
     return array(
       id(new PhabricatorSearchTextField())

src/applications/diviner/query/DivinerAtomSearchEngine.php

@@ -10,6 +10,10 @@ final class DivinerAtomSearchEngine extends PhabricatorApplicationSearchEngine {
     return 'PhabricatorDivinerApplication';
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   public function buildSavedQueryFromRequest(AphrontRequest $request) {
     $saved = new PhabricatorSavedQuery();
 

src/applications/files/query/PhabricatorFileSearchEngine.php

@@ -11,6 +11,10 @@ final class PhabricatorFileSearchEngine
     return 'PhabricatorFilesApplication';
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   public function newQuery() {
     return new PhabricatorFileQuery();
   }

src/applications/herald/query/HeraldTranscriptSearchEngine.php

@@ -11,6 +11,10 @@ final class HeraldTranscriptSearchEngine
     return 'PhabricatorHeraldApplication';
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   public function buildSavedQueryFromRequest(AphrontRequest $request) {
     $saved = new PhabricatorSavedQuery();
 

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

@@ -31,7 +31,7 @@ final class ManiphestTaskSearchEngine
   }
 
   public function getResultTypeDescription() {
-    return pht('Tasks');
+    return pht('Maniphest Tasks');
   }
 
   public function getApplicationClassName() {

src/applications/metamta/query/PhabricatorMetaMTAMailSearchEngine.php

@@ -11,6 +11,10 @@ final class PhabricatorMetaMTAMailSearchEngine
     return 'PhabricatorMetaMTAApplication';
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   public function newQuery() {
     return new PhabricatorMetaMTAMailQuery();
   }

src/applications/oauthserver/query/PhabricatorOAuthServerClientSearchEngine.php

@@ -11,6 +11,10 @@ final class PhabricatorOAuthServerClientSearchEngine
     return 'PhabricatorOAuthServerApplication';
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   public function newQuery() {
     return id(new PhabricatorOAuthServerClientQuery());
   }

src/applications/owners/query/PhabricatorOwnersPackageSearchEngine.php

@@ -15,6 +15,10 @@ final class PhabricatorOwnersPackageSearchEngine
     return new PhabricatorOwnersPackageQuery();
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   protected function buildCustomSearchFields() {
     return array(
       id(new PhabricatorSearchDatasourceField())

src/applications/packages/query/PhabricatorPackagesPackageSearchEngine.php

@@ -15,6 +15,10 @@ final class PhabricatorPackagesPackageSearchEngine
     return id(new PhabricatorPackagesPackageQuery());
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   protected function buildQueryFromParameters(array $map) {
     $query = $this->newQuery();
 

src/applications/packages/query/PhabricatorPackagesPublisherSearchEngine.php

@@ -15,6 +15,10 @@ final class PhabricatorPackagesPublisherSearchEngine
     return id(new PhabricatorPackagesPublisherQuery());
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   protected function buildQueryFromParameters(array $map) {
     $query = $this->newQuery();
 

src/applications/packages/query/PhabricatorPackagesVersionSearchEngine.php

@@ -15,6 +15,10 @@ final class PhabricatorPackagesVersionSearchEngine
     return id(new PhabricatorPackagesVersionQuery());
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   protected function buildQueryFromParameters(array $map) {
     $query = $this->newQuery();
 

src/applications/phrequent/query/PhrequentSearchEngine.php

@@ -10,6 +10,11 @@ final class PhrequentSearchEngine extends PhabricatorApplicationSearchEngine {
     return 'PhabricatorPhrequentApplication';
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
+
   public function getPageSize(PhabricatorSavedQuery $saved) {
     return $saved->getParameter('limit', 1000);
   }

src/applications/phurl/query/PhabricatorPhurlURLSearchEngine.php

@@ -4,7 +4,7 @@ final class PhabricatorPhurlURLSearchEngine
   extends PhabricatorApplicationSearchEngine {
 
   public function getResultTypeDescription() {
-    return pht('Shortened URLs');
+    return pht('Phurl URLs');
   }
 
   public function getApplicationClassName() {

src/applications/project/query/PhabricatorProjectColumnSearchEngine.php

@@ -11,6 +11,10 @@ final class PhabricatorProjectColumnSearchEngine
     return 'PhabricatorProjectApplication';
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   public function newQuery() {
     return new PhabricatorProjectColumnQuery();
   }
@@ -25,7 +29,6 @@ final class PhabricatorProjectColumnSearchEngine
     );
   }
 
-
   protected function buildQueryFromParameters(array $map) {
     $query = $this->newQuery();
 

src/applications/releeph/query/ReleephBranchSearchEngine.php

@@ -9,6 +9,10 @@ final class ReleephBranchSearchEngine
     return pht('Releeph Branches');
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   public function getApplicationClassName() {
     return 'PhabricatorReleephApplication';
   }

src/applications/releeph/query/ReleephProductSearchEngine.php

@@ -11,6 +11,10 @@ final class ReleephProductSearchEngine
     return 'PhabricatorReleephApplication';
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   public function buildSavedQueryFromRequest(AphrontRequest $request) {
     $saved = new PhabricatorSavedQuery();
 

src/applications/releeph/query/ReleephRequestSearchEngine.php

@@ -14,6 +14,10 @@ final class ReleephRequestSearchEngine
     return 'PhabricatorReleephApplication';
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   public function setBranch(ReleephBranch $branch) {
     $this->branch = $branch;
     return $this;

src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php

@@ -11,6 +11,10 @@ final class PhabricatorSearchApplicationSearchEngine
     return 'PhabricatorSearchApplication';
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   public function buildSavedQueryFromRequest(AphrontRequest $request) {
     $saved = new PhabricatorSavedQuery();
 

src/applications/transactions/query/PhabricatorEditEngineSearchEngine.php

@@ -15,6 +15,10 @@ final class PhabricatorEditEngineSearchEngine
     return id(new PhabricatorEditEngineQuery());
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   protected function buildQueryFromParameters(array $map) {
     $query = $this->newQuery();
     return $query;

src/infrastructure/daemon/workers/query/PhabricatorWorkerBulkJobSearchEngine.php

@@ -4,7 +4,7 @@ final class PhabricatorWorkerBulkJobSearchEngine
   extends PhabricatorApplicationSearchEngine {
 
   public function getResultTypeDescription() {
-    return pht('Bulk Jobs');
+    return pht('Daemon Bulk Jobs');
   }
 
   public function getApplicationClassName() {
@@ -15,6 +15,10 @@ final class PhabricatorWorkerBulkJobSearchEngine
     return id(new PhabricatorWorkerBulkJobQuery());
   }
 
+  public function canUseInPanelContext() {
+    return false;
+  }
+
   protected function buildQueryFromParameters(array $map) {
     $query = $this->newQuery();