revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 08:42:41 +01:00
Code Issues Releases Wiki Activity

Crop screenshot thumbs in Maniphest

Browse source 
Summary:
If you name an attached file something like
"derpderpderpderpderdperdperpereprederpderplolololololo.png", the display
overflows. Crop and shorten it so that it looks decent. Show the full name as
the image title.

Test Plan:
Named a file "derpderpderpderpderdperdperpereprederpderplolololololo.png" and
got a sensible display out of it.

Reviewed By: tuomaspelkonen
Reviewers: tuomaspelkonen, jungejason, aran
CC: aran, tuomaspelkonen
Differential Revision: 389
This commit is contained in:
epriestley 2011-05-31 19:42:28 -07:00
parent 8e2d5e0422
commit bfe73f585f
3 changed files with 20 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/__celerity_resource_map__.php
View file

@ -9,7 +9,7 @@
celerity_register_resource_map(array( celerity_register_resource_map(array(
'aphront-attached-file-view-css' => 'aphront-attached-file-view-css' =>
array( array(
'uri' => '/res/bac9f95c/rsrc/css/aphront/attached-file-view.css', 'uri' => '/res/a6ca5487/rsrc/css/aphront/attached-file-view.css',
'type' => 'css', 'type' => 'css',
'requires' => 'requires' =>
array( array(

16
src/view/layout/filepreview/AphrontFilePreviewView.php
View file

@ -36,6 +36,7 @@ final class AphrontFilePreviewView extends AphrontView {
'src' => $file->getThumb160x120URI(), 'src' => $file->getThumb160x120URI(),
'width' => 160, 'width' => 160,
'height' => 120, 'height' => 120,
'title' => $file->getName(),
)); ));
$link = phutil_render_tag( $link = phutil_render_tag(
'a', 'a',
@ -45,12 +46,25 @@ final class AphrontFilePreviewView extends AphrontView {
), ),
$img); $img);
$display_name = $file->getName();
if (strlen($display_name) > 22) {
$display_name =
substr($display_name, 0, 11).
"\xE2\x80\xA6".
substr($display_name, -9);
}
return return
'<div class="aphront-file-preview-view"> '<div class="aphront-file-preview-view">
<div class="aphront-file-preview-thumb">'. <div class="aphront-file-preview-thumb">'.
$link. $link.
'</div>'. '</div>'.
phutil_escape_html($file->getName()). phutil_render_tag(
'span',
array(
'title' => $file->getName(),
),
phutil_escape_html($display_name)).
'</div>'; '</div>';
} }

4
webroot/rsrc/css/aphront/attached-file-view.css
View file

@ -29,6 +29,9 @@
text-align: center; text-align: center;
font-size: 11px; font-size: 11px;
color: #333333; color: #333333;
overflow: hidden;
width: 166px;
white-space: nowrap;
} }
.aphront-file-preview-thumb { .aphront-file-preview-thumb {
@ -36,4 +39,5 @@
border: 1px solid #000000; border: 1px solid #000000;
background: #ffffff; background: #ffffff;
margin-bottom: 2px; margin-bottom: 2px;
width: 160px;
} }