From c02a588b4e058836bbb8d6b2bb4774afb0df6b47 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Tue, 16 Oct 2012 10:33:37 -0700
Subject: [PATCH] Remove "admin page" color/styles

Summary: These haven't had any effect since the redesign, and we're moving to a more granular policy model so it probably doesn't make sense to ever restore them.

Test Plan: Grepped for "admin" and removed all relevant code.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D3710
---
 .../base/controller/PhabricatorController.php |  5 -----
 .../herald/controller/HeraldController.php    |  1 -
 src/view/page/PhabricatorStandardPageView.php | 21 -------------------
 3 files changed, 27 deletions(-)

diff --git a/src/applications/base/controller/PhabricatorController.php b/src/applications/base/controller/PhabricatorController.php
index 2c1148c545..1538246ecf 100644
--- a/src/applications/base/controller/PhabricatorController.php
+++ b/src/applications/base/controller/PhabricatorController.php
@@ -139,11 +139,6 @@ abstract class PhabricatorController extends AphrontController {
     $view = new PhabricatorStandardPageView();
     $view->setRequest($this->getRequest());
     $view->setController($this);
-
-    if ($this->shouldRequireAdmin()) {
-      $view->setIsAdminInterface(true);
-    }
-
     return $view;
   }
 
diff --git a/src/applications/herald/controller/HeraldController.php b/src/applications/herald/controller/HeraldController.php
index 7497e366f4..ef246503fd 100644
--- a/src/applications/herald/controller/HeraldController.php
+++ b/src/applications/herald/controller/HeraldController.php
@@ -27,7 +27,6 @@ abstract class HeraldController extends PhabricatorController {
     $page->setGlyph("\xE2\x98\xBF");
 
     $page->appendChild($view);
-    $page->setIsAdminInterface(idx($data, 'admin'));
 
     $response = new AphrontWebpageResponse();
     return $response->setContent($page->render());
diff --git a/src/view/page/PhabricatorStandardPageView.php b/src/view/page/PhabricatorStandardPageView.php
index 8e9e370c7f..8b10b287a8 100644
--- a/src/view/page/PhabricatorStandardPageView.php
+++ b/src/view/page/PhabricatorStandardPageView.php
@@ -24,19 +24,13 @@ final class PhabricatorStandardPageView extends AphrontPageView {
   private $bodyContent;
   private $menuContent;
   private $request;
-  private $isAdminInterface;
   private $showChrome = true;
   private $isFrameable = false;
   private $disableConsole;
   private $searchDefaultScope;
   private $pageObjects = array();
   private $controller;
-  private $deviceReady;
 
-  public function setDeviceReady($device_ready) {
-    $this->deviceReady = $device_ready;
-    return $this;
-  }
 
   public function setController(AphrontController $controller) {
     $this->controller = $controller;
@@ -47,15 +41,6 @@ final class PhabricatorStandardPageView extends AphrontPageView {
     return $this->controller;
   }
 
-  public function setIsAdminInterface($is_admin_interface) {
-    $this->isAdminInterface = $is_admin_interface;
-    return $this;
-  }
-
-  public function getIsAdminInterface() {
-    return $this->isAdminInterface;
-  }
-
   public function setRequest($request) {
     $this->request = $request;
     return $this;
@@ -303,11 +288,6 @@ final class PhabricatorStandardPageView extends AphrontPageView {
       }
     }
 
-    $admin_class = null;
-    if ($this->getIsAdminInterface()) {
-      $admin_class = 'phabricator-admin-page-view';
-    }
-
     $header_chrome = null;
     $footer_chrome = null;
     if ($this->getShowChrome()) {
@@ -341,7 +321,6 @@ final class PhabricatorStandardPageView extends AphrontPageView {
 
     $classes = array(
       'phabricator-standard-page',
-      $admin_class,
       $device_guess,
     );
     $classes = implode(' ', $classes);