From c05cb1ba6ddd695312a2affd609b5401dfde0d66 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 11 Jan 2017 14:51:52 -0800 Subject: [PATCH] Make "Audit Requested" put commits into the "Needs Audit" state Summary: Fixes T7504. I think that task legitimately describes a bug and that the current behavior is counterintuitive. Test Plan: Manually added an auditor to a commit with none; saw it become "Audit Required" as an overall state. Reviewers: chad Reviewed By: chad Maniphest Tasks: T7504 Differential Revision: https://secure.phabricator.com/D17185 --- .../repository/storage/PhabricatorRepositoryCommit.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/applications/repository/storage/PhabricatorRepositoryCommit.php b/src/applications/repository/storage/PhabricatorRepositoryCommit.php index 704686cfb1..fd3e5fe97a 100644 --- a/src/applications/repository/storage/PhabricatorRepositoryCommit.php +++ b/src/applications/repository/storage/PhabricatorRepositoryCommit.php @@ -256,6 +256,7 @@ final class PhabricatorRepositoryCommit foreach ($requests as $request) { switch ($request->getAuditStatus()) { case PhabricatorAuditStatusConstants::AUDIT_REQUIRED: + case PhabricatorAuditStatusConstants::AUDIT_REQUESTED: $any_need = true; break; case PhabricatorAuditStatusConstants::ACCEPTED: