From c0a52201a8991aa71e84b01932b984bb233fb96c Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 13 Oct 2015 08:41:49 -0700 Subject: [PATCH] (stable) Work around an issue with custom "users" fields in Maniphest Summary: Fixes T9558. The recent changes to validate PHID fields don't work cleanly with this gross hack. This can probably be unwound now but it will definitely get fixed in T9132 so I may just wait for that. Test Plan: Edited a custom "users" field in Maniphest. This should only affect Maniphest because it has a weird hack. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9558 Differential Revision: https://secure.phabricator.com/D14264 --- .../maniphest/controller/ManiphestTaskEditController.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/applications/maniphest/controller/ManiphestTaskEditController.php b/src/applications/maniphest/controller/ManiphestTaskEditController.php index 703bb61768..5c4a3b4862 100644 --- a/src/applications/maniphest/controller/ManiphestTaskEditController.php +++ b/src/applications/maniphest/controller/ManiphestTaskEditController.php @@ -198,7 +198,8 @@ final class ManiphestTaskEditController extends ManiphestController { // in a meaningful way. For now, build User objects. Once the Maniphest // objects exist, this will switch over automatically. This is a big // hack but shouldn't be long for this world. - $placeholder_editor = new PhabricatorUserProfileEditor(); + $placeholder_editor = id(new PhabricatorUserProfileEditor()) + ->setActor($viewer); $field_errors = $aux_field->validateApplicationTransactions( $placeholder_editor,