revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 16:52:41 +01:00
Code Issues Releases Wiki Activity

Update "phabricator/" for "topological" API changes

Browse source 
Summary: Ref T13325.

Test Plan:
  - Grepped for `topograph`.
  - Viewed a task graph since that's easy, looked fine.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13325

Differential Revision: https://secure.phabricator.com/D20599
This commit is contained in:
epriestley 2019-06-20 12:13:28 -07:00
parent 53f8ad14fa
commit c0dc411d23
3 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/applications/harbormaster/engine/HarbormasterBuildGraph.php
View file

@ -25,8 +25,7 @@ final class HarbormasterBuildGraph extends AbstractDirectedGraph {
$graph = id(new HarbormasterBuildGraph($steps_by_phid)) $graph = id(new HarbormasterBuildGraph($steps_by_phid))
->addNodes($step_phids); ->addNodes($step_phids);
$raw_results = $raw_results = $graph->getNodesInRoughTopologicalOrder();
$graph->getBestEffortTopographicallySortedNodes();
$results = array(); $results = array();
foreach ($raw_results as $node) { foreach ($raw_results as $node) {

4
src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php
View file

@ -398,7 +398,7 @@ final class PhabricatorRepositoryDiscoveryEngine
} }
} }
// Now, sort them topographically. // Now, sort them topologically.
$commits = $this->reduceGraph($graph); $commits = $this->reduceGraph($graph);
$refs = array(); $refs = array();
@ -437,7 +437,7 @@ final class PhabricatorRepositoryDiscoveryEngine
$graph = new PhutilDirectedScalarGraph(); $graph = new PhutilDirectedScalarGraph();
$graph->addNodes($edges); $graph->addNodes($edges);
$commits = $graph->getTopographicallySortedNodes(); $commits = $graph->getNodesInTopologicalOrder();
// NOTE: We want the most ancestral nodes first, so we need to reverse the // NOTE: We want the most ancestral nodes first, so we need to reverse the
// list we get out of AbstractDirectedGraph. // list we get out of AbstractDirectedGraph.

2
src/infrastructure/graph/PhabricatorObjectGraph.php
View file

@ -189,7 +189,7 @@ abstract class PhabricatorObjectGraph
$order = id(new PhutilDirectedScalarGraph()) $order = id(new PhutilDirectedScalarGraph())
->addNodes($ancestry) ->addNodes($ancestry)
->getTopographicallySortedNodes(); ->getNodesInTopologicalOrder();
$ancestry = array_select_keys($ancestry, $order); $ancestry = array_select_keys($ancestry, $order);