revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 14:30:56 +01:00
Code Issues Releases Wiki Activity

Clean up remaining default column logic for boards

Browse source 
Summary: See D10189. We should never hit this anymore, so clean it up.

Test Plan:
  - Reloaded a board, saw everything stay where it was before the change.
  - Added a new task to the project, saw it show up in backlog.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D10200
This commit is contained in:
epriestley 2014-08-08 16:22:11 -07:00
parent 664507e450
commit c0dc5ca898
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/applications/project/controller/PhabricatorProjectBoardViewController.php
View file

@ -166,17 +166,17 @@ final class PhabricatorProjectBoardViewController
} }
$task_map = array(); $task_map = array();
$default_phid = $columns[0]->getPHID();
foreach ($tasks as $task) { foreach ($tasks as $task) {
$task_phid = $task->getPHID(); $task_phid = $task->getPHID();
if (empty($positions[$task_phid])) {
$column_phid = null; // This shouldn't normally be possible because we create positions on
if (isset($positions[$task_phid])) { // demand, but we might have raced as an object was removed from the
$column_phid = $positions[$task_phid]->getColumnPHID(); // board. Just drop the task if we don't have a position for it.
continue;
} }
$column_phid = nonempty($column_phid, $default_phid);
$task_map[$column_phid][] = $task_phid; $position = $positions[$task_phid];
$task_map[$position->getColumnPHID()][] = $task_phid;
} }
// If we're showing the board in "natural" order, sort columns by their // If we're showing the board in "natural" order, sort columns by their