MetaMTA - make the new mail app UI a little less bad

Summary: Ref T5791. Makes the result page a little less ugly and adds the time created. Makes the detail page include more useful information about the message.

Test Plan: viewed results page and detail page and they looked better

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T5791

Differential Revision: https://secure.phabricator.com/D13410

src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php

@@ -49,6 +49,26 @@ final class PhabricatorMetaMTAMailViewController
       ->setUser($viewer)
       ->setObject($mail);
 
+    $properties->addProperty(
+      pht('ID'),
+      $mail->getID());
+
+    $properties->addProperty(
+      pht('Status'),
+      $mail->getStatus());
+
+    if ($mail->getMessage()) {
+      $properties->addProperty(
+        pht('Status Details'),
+        $mail->getMessage());
+    }
+
+    if ($mail->getRelatedPHID()) {
+      $properties->addProperty(
+        pht('Related Object'),
+        $viewer->renderHandle($mail->getRelatedPHID()));
+    }
+
     if ($mail->getActorPHID()) {
       $actor_str = $viewer->renderHandle($mail->getActorPHID());
     } else {

src/applications/metamta/query/PhabricatorMetaMTAMailSearchEngine.php

@@ -101,18 +101,16 @@ final class PhabricatorMetaMTAMailSearchEngine
 
     foreach ($mails as $mail) {
       if ($mail->hasSensitiveContent()) {
-        $header = pht(
-          'Mail %d: < content redacted >',
-          $mail->getID());
+        $header = pht('< content redacted >');
       } else {
-        $header = pht(
-          'Mail %d: %s',
-          $mail->getID(),
-          $mail->getSubject());
+        $header = $mail->getSubject();
       }
 
       $item = id(new PHUIObjectItemView())
+        ->setUser($viewer)
         ->setObject($mail)
+        ->setEpoch($mail->getDateCreated())
+        ->setObjectName('Mail '.$mail->getID())
         ->setHeader($header)
         ->setHref($this->getURI('detail/'.$mail->getID()));
       $list->addItem($item);