revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 00:32:42 +01:00
Code Issues Releases Wiki Activity

Prefer MySQLi over MySQL

Browse source 
Summary: Makes sense with `QueryFuture`.

Test Plan: Switched secure.phabricator.com to MySQLi and nothing exploded.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5066
This commit is contained in:
vrana 2013-02-22 03:37:00 -08:00
parent e9b5eb8609
commit c1f234759b
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
conf/default.conf.php
View file

@ -174,7 +174,9 @@ return array(
// Phabricator supports PHP extensions MySQL and MySQLi. It is possible to // Phabricator supports PHP extensions MySQL and MySQLi. It is possible to
// implement also other access mechanism (e.g. PDO_MySQL). The class must // implement also other access mechanism (e.g. PDO_MySQL). The class must
// extend AphrontMySQLDatabaseConnectionBase. // extend AphrontMySQLDatabaseConnectionBase.
'mysql.implementation' => 'AphrontMySQLDatabaseConnection', 'mysql.implementation' => (extension_loaded('mysqli')
? 'AphrontMySQLiDatabaseConnection'
: 'AphrontMySQLDatabaseConnection'),
// -- Notifications --------------------------------------------------------- // // -- Notifications --------------------------------------------------------- //

4
src/applications/config/option/PhabricatorMySQLConfigOptions.php
View file

@ -43,7 +43,9 @@ final class PhabricatorMySQLConfigOptions
$this->newOption( $this->newOption(
'mysql.implementation', 'mysql.implementation',
'class', 'class',
'AphrontMySQLDatabaseConnection') (extension_loaded('mysqli')
? 'AphrontMySQLiDatabaseConnection'
: 'AphrontMySQLDatabaseConnection'))
->setLocked(true) ->setLocked(true)
->setBaseClass('AphrontMySQLDatabaseConnectionBase') ->setBaseClass('AphrontMySQLDatabaseConnectionBase')
->setSummary( ->setSummary(