Increase visibility of PhabricatorController::buildApplicationMenu methods

Summary: Ref T6822. This method needs to be `public` because it is called from `PhabricatorApplicationSearchController::buildApplicationMenu()`.

Test Plan: I wouldn't expect //increasing// method visibility to break anything.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6822

Differential Revision: https://secure.phabricator.com/D11416

src/applications/audit/controller/PhabricatorAuditController.php

@@ -18,7 +18,7 @@ abstract class PhabricatorAuditController extends PhabricatorController {
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView()->getMenu();
   }
 

src/applications/auth/controller/config/PhabricatorAuthProviderConfigController.php

@@ -16,7 +16,7 @@ abstract class PhabricatorAuthProviderConfigController
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView($for_app = true)->getMenu();
   }
 

src/applications/base/controller/PhabricatorController.php

@@ -425,7 +425,7 @@ abstract class PhabricatorController extends AphrontController {
       array_filter($phids));
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return null;
   }
 

src/applications/calendar/controller/PhabricatorCalendarController.php

@@ -20,7 +20,7 @@ abstract class PhabricatorCalendarController extends PhabricatorController {
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView()->getMenu();
   }
 

src/applications/conduit/controller/PhabricatorConduitController.php

@@ -20,7 +20,7 @@ abstract class PhabricatorConduitController extends PhabricatorController {
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView()->getMenu();
   }
 

src/applications/config/controller/PhabricatorConfigController.php

@@ -26,7 +26,7 @@ abstract class PhabricatorConfigController extends PhabricatorController {
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView(null, true)->getMenu();
   }
 

src/applications/conpherence/controller/ConpherenceController.php

@@ -4,7 +4,7 @@ abstract class ConpherenceController extends PhabricatorController {
 
   private $conpherences;
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     $nav = new PHUIListView();
 
     $nav->newLink(

src/applications/countdown/controller/PhabricatorCountdownController.php

@@ -21,7 +21,7 @@ abstract class PhabricatorCountdownController extends PhabricatorController {
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView($for_app = true)->getMenu();
   }
 

src/applications/differential/controller/DifferentialController.php

@@ -29,7 +29,7 @@ abstract class DifferentialController extends PhabricatorController {
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 

src/applications/diviner/controller/DivinerController.php

@@ -7,7 +7,7 @@ abstract class DivinerController extends PhabricatorController {
     return AphrontSideNavFilterView::newFromMenu($menu);
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildMenu();
   }
 

src/applications/drydock/controller/DrydockController.php

@@ -4,7 +4,7 @@ abstract class DrydockController extends PhabricatorController {
 
   public abstract function buildSideNavView();
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView()->getMenu();
   }
 

src/applications/feed/controller/PhabricatorFeedController.php

@@ -37,7 +37,7 @@ abstract class PhabricatorFeedController extends PhabricatorController {
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView()->getMenu();
   }
 

src/applications/files/controller/PhabricatorFileController.php

@@ -7,7 +7,7 @@ abstract class PhabricatorFileController extends PhabricatorController {
     return AphrontSideNavFilterView::newFromMenu($menu);
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildMenu($for_devices = true);
   }
 

src/applications/harbormaster/controller/HarbormasterBuildableListController.php

@@ -39,7 +39,7 @@ final class HarbormasterBuildableListController extends HarbormasterController {
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 

src/applications/harbormaster/controller/HarbormasterPlanListController.php

@@ -40,7 +40,7 @@ final class HarbormasterPlanListController extends HarbormasterPlanController {
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 

src/applications/herald/controller/HeraldController.php

@@ -16,7 +16,7 @@ abstract class HeraldController extends PhabricatorController {
     return $response->setContent($page->render());
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 

src/applications/legalpad/controller/LegalpadController.php

@@ -22,7 +22,7 @@ abstract class LegalpadController extends PhabricatorController {
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNav(true)->getMenu();
   }
 

src/applications/macro/controller/PhabricatorMacroController.php

@@ -20,7 +20,7 @@ abstract class PhabricatorMacroController extends PhabricatorController {
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView($for_app = true)->getMenu();
   }
 

src/applications/mailinglists/controller/PhabricatorMailingListsController.php

@@ -21,7 +21,7 @@ abstract class PhabricatorMailingListsController extends PhabricatorController {
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 

src/applications/meta/controller/PhabricatorApplicationsController.php

@@ -17,7 +17,7 @@ abstract class PhabricatorApplicationsController extends PhabricatorController {
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 

src/applications/owners/controller/PhabricatorOwnersController.php

@@ -58,7 +58,7 @@ abstract class PhabricatorOwnersController extends PhabricatorController {
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView()->getMenu();
   }
 

src/applications/passphrase/controller/PassphraseController.php

@@ -21,7 +21,7 @@ abstract class PassphraseController extends PhabricatorController {
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 

src/applications/paste/controller/PhabricatorPasteController.php

@@ -21,7 +21,7 @@ abstract class PhabricatorPasteController extends PhabricatorController {
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 

src/applications/people/controller/PhabricatorPeopleController.php

@@ -28,7 +28,7 @@ abstract class PhabricatorPeopleController extends PhabricatorController {
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView()->getMenu();
   }
 

src/applications/phame/controller/PhameController.php

@@ -103,7 +103,7 @@ abstract class PhameController extends PhabricatorController {
     return $stories;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->renderSideNavFilterView()->getMenu();
   }
 

src/applications/pholio/controller/PholioController.php

@@ -33,7 +33,7 @@ abstract class PholioController extends PhabricatorController {
     return $crumbs;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 

src/applications/phriction/controller/PhrictionController.php

@@ -22,7 +22,7 @@ abstract class PhrictionController extends PhabricatorController {
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 

src/applications/releeph/controller/ReleephController.php

@@ -34,7 +34,7 @@ abstract class ReleephController extends PhabricatorController {
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 

src/applications/search/controller/PhabricatorApplicationSearchController.php

@@ -355,7 +355,7 @@ final class PhabricatorApplicationSearchController
       ));
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->getDelegatingController()->buildApplicationMenu();
   }
 

src/applications/settings/controller/PhabricatorSettingsMainController.php

@@ -151,7 +151,7 @@ final class PhabricatorSettingsMainController
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     $panels = $this->buildPanels();
     return $this->renderSideNav($panels)->getMenu();
   }

src/applications/slowvote/controller/PhabricatorSlowvoteController.php

@@ -22,7 +22,7 @@ abstract class PhabricatorSlowvoteController extends PhabricatorController {
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 

src/applications/tokens/controller/PhabricatorTokenController.php

@@ -13,7 +13,7 @@ abstract class PhabricatorTokenController extends PhabricatorController {
     return $nav;
   }
 
-  protected function buildApplicationMenu() {
+  public function buildApplicationMenu() {
     return $this->buildSideNav()->getMenu();
   }