Removie panelview backgrounds from Herald.

Summary: Prior to re-doing responsive form CSS, update the Herald app for no panel backgrounds.

Test Plan: Went through Herald application, see no panels.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4545

src/applications/herald/controller/HeraldHomeController.php

@@ -92,6 +92,7 @@ final class HeraldHomeController extends HeraldController {
     $panel = new AphrontPanelView();
     $panel->appendChild($list_view);
     $panel->appendChild($pager);
+    $panel->setNoBackground();
 
     $panel->setHeader("Herald: {$rule_desc} Rules for {$content_desc}");
 

src/applications/herald/controller/HeraldNewController.php

@@ -59,20 +59,21 @@ final class HeraldNewController extends HeraldController {
       ->setAction('/herald/rule/')
       ->appendChild(
         id(new AphrontFormSelectControl())
-          ->setLabel('New rule for')
+          ->setLabel(pht('New rule for'))
           ->setName('content_type')
           ->setValue($this->contentType)
           ->setOptions($content_type_map))
       ->appendChild($radio)
       ->appendChild(
         id(new AphrontFormSubmitControl())
-          ->setValue('Create Rule')
+          ->setValue(pht('Create Rule'))
           ->addCancelButton('/herald/view/'.$this->contentType.'/'));
 
     $panel = new AphrontPanelView();
-    $panel->setHeader('Create New Herald Rule');
+    $panel->setHeader(pht('Create New Herald Rule'));
     $panel->setWidth(AphrontPanelView::WIDTH_FULL);
     $panel->appendChild($form);
+    $panel->setNoBackground();
 
     $nav = $this->renderNav();
     $nav->selectFilter('new');

src/applications/herald/controller/HeraldRuleController.php

@@ -173,10 +173,11 @@ final class HeraldRuleController extends HeraldController {
     $panel = new AphrontPanelView();
     $panel->setHeader(
       $rule->getID()
-        ? 'Edit Herald Rule'
-        : 'Create Herald Rule');
+        ? pht('Edit Herald Rule')
+        : pht('Create Herald Rule'));
     $panel->setWidth(AphrontPanelView::WIDTH_WIDE);
     $panel->appendChild($form);
+    $panel->setNoBackground();
 
     $nav = $this->renderNav();
     $nav->selectFilter(

src/applications/herald/controller/HeraldRuleEditHistoryController.php

@@ -31,8 +31,9 @@ final class HeraldRuleEditHistoryController extends HeraldController {
       ->setUser($this->getRequest()->getUser());
 
     $panel = new AphrontPanelView();
-    $panel->setHeader('Edit History');
+    $panel->setHeader(pht('Edit History'));
     $panel->appendChild($list_view);
+    $panel->setNoBackground();
 
     $nav = $this->renderNav();
     $nav->selectFilter('history');

src/applications/herald/controller/HeraldTestConsoleController.php

@@ -103,18 +103,19 @@ final class HeraldTestConsoleController extends HeraldController {
         'results of a dry run on the object.</p>')
       ->appendChild(
         id(new AphrontFormTextControl())
-          ->setLabel('Object Name')
+          ->setLabel(pht('Object Name'))
           ->setName('object_name')
           ->setError($e_name)
           ->setValue($object_name))
       ->appendChild(
         id(new AphrontFormSubmitControl())
-          ->setValue('Test Rules'));
+          ->setValue(pht('Test Rules')));
 
     $panel = new AphrontPanelView();
-    $panel->setHeader('Test Herald Rules');
+    $panel->setHeader(pht('Test Herald Rules'));
     $panel->setWidth(AphrontPanelView::WIDTH_FULL);
     $panel->appendChild($form);
+    $panel->setNoBackground();
 
     $nav = $this->renderNav();
     $nav->selectFilter('test');

src/applications/herald/controller/HeraldTranscriptController.php

@@ -323,8 +323,9 @@ final class HeraldTranscriptController extends HeraldController {
       ));
 
     $panel = new AphrontPanelView();
-    $panel->setHeader('Actions Taken');
+    $panel->setHeader(pht('Actions Taken'));
     $panel->appendChild($table);
+    $panel->setNoBackground();
 
     return $panel;
   }

src/applications/herald/controller/HeraldTranscriptListController.php

@@ -90,9 +90,10 @@ final class HeraldTranscriptListController extends HeraldController {
 
     // Render the whole page.
     $panel = new AphrontPanelView();
-    $panel->setHeader('Herald Transcripts');
+    $panel->setHeader(pht('Herald Transcripts'));
     $panel->appendChild($table);
     $panel->appendChild($pager);
+    $panel->setNoBackground();
 
     $nav = $this->renderNav();
     $nav->selectFilter('transcript');