From c317d16bdd565d34eaad0850aa505fffc8ef811e Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Mon, 15 Mar 2021 10:02:34 -0700
Subject: [PATCH] Lift peculiar side effect of path indexing out of indexer

Summary:
Ref T13639. Updating the affected path table has a peculiar side effect from D19426, which is a simplification of a peculiar side effect from earlier.

Don't condition Owners behavior on path index behavior.

Test Plan: Created a revision.

Maniphest Tasks: T13639

Differential Revision: https://secure.phabricator.com/D21614
---
 .../editor/DifferentialTransactionEditor.php           | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php
index 964cf38722..af81af73a8 100644
--- a/src/applications/differential/editor/DifferentialTransactionEditor.php
+++ b/src/applications/differential/editor/DifferentialTransactionEditor.php
@@ -349,6 +349,9 @@ final class DifferentialTransactionEditor
         case DifferentialRevisionUpdateTransaction::TRANSACTIONTYPE:
           $diff = $this->requireDiff($xaction->getNewValue(), true);
 
+          $this->ownersDiff = $diff;
+          $this->ownersChangesets = $diff->getChangesets();
+
           // Update these denormalized index tables when we attach a new
           // diff to a revision.
 
@@ -1299,13 +1302,6 @@ final class DifferentialTransactionEditor
       $paths[] = $path_prefix.'/'.$changeset->getFilename();
     }
 
-    // If this change affected paths, save the changesets so we can apply
-    // Owners rules to them later.
-    if ($paths) {
-      $this->ownersDiff = $diff;
-      $this->ownersChangesets = $changesets;
-    }
-
     // Mark this as also touching all parent paths, so you can see all pending
     // changes to any file within a directory.
     $all_paths = array();