revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 02:02:41 +01:00
Code Issues Releases Wiki Activity

Lift peculiar side effect of path indexing out of indexer

Browse source 
Summary:
Ref T13639. Updating the affected path table has a peculiar side effect from D19426, which is a simplification of a peculiar side effect from earlier.

Don't condition Owners behavior on path index behavior.

Test Plan: Created a revision.

Maniphest Tasks: T13639

Differential Revision: https://secure.phabricator.com/D21614
This commit is contained in:
epriestley 2021-03-15 10:02:34 -07:00
parent bcd592cf7e
commit c317d16bdd
1 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/applications/differential/editor/DifferentialTransactionEditor.php
View file

@ -349,6 +349,9 @@ final class DifferentialTransactionEditor
case DifferentialRevisionUpdateTransaction::TRANSACTIONTYPE: case DifferentialRevisionUpdateTransaction::TRANSACTIONTYPE:
$diff = $this->requireDiff($xaction->getNewValue(), true); $diff = $this->requireDiff($xaction->getNewValue(), true);
$this->ownersDiff = $diff;
$this->ownersChangesets = $diff->getChangesets();
// Update these denormalized index tables when we attach a new // Update these denormalized index tables when we attach a new
// diff to a revision. // diff to a revision.
@ -1299,13 +1302,6 @@ final class DifferentialTransactionEditor
$paths[] = $path_prefix.'/'.$changeset->getFilename(); $paths[] = $path_prefix.'/'.$changeset->getFilename();
} }
// If this change affected paths, save the changesets so we can apply
// Owners rules to them later.
if ($paths) {
$this->ownersDiff = $diff;
$this->ownersChangesets = $changesets;
}
// Mark this as also touching all parent paths, so you can see all pending // Mark this as also touching all parent paths, so you can see all pending
// changes to any file within a directory. // changes to any file within a directory.
$all_paths = array(); $all_paths = array();