From c3563ca15608ba0474aa4713abcdf85ce1a972e7 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 25 Mar 2019 07:27:24 -0700 Subject: [PATCH] Correct use of the paging API in Phame Summary: Ref T13266. This callsite is using the older API; swap it to use pagers. Test Plan: Viewed a Phame blog post with siblings, saw the previous/next posts linked. Reviewers: amckinley Reviewed By: amckinley Subscribers: nicolast Maniphest Tasks: T13263, T13266 Differential Revision: https://secure.phabricator.com/D20319 --- .../controller/post/PhamePostViewController.php | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/applications/phame/controller/post/PhamePostViewController.php b/src/applications/phame/controller/post/PhamePostViewController.php index 11d94d2f94..4fb01c4def 100644 --- a/src/applications/phame/controller/post/PhamePostViewController.php +++ b/src/applications/phame/controller/post/PhamePostViewController.php @@ -304,6 +304,15 @@ final class PhamePostViewController private function loadAdjacentPosts(PhamePost $post) { $viewer = $this->getViewer(); + $pager = id(new AphrontCursorPagerView()) + ->setPageSize(1); + + $prev_pager = id(clone $pager) + ->setAfterID($post->getID()); + + $next_pager = id(clone $pager) + ->setBeforeID($post->getID()); + $query = id(new PhamePostQuery()) ->setViewer($viewer) ->withVisibility(array(PhameConstants::VISIBILITY_PUBLISHED)) @@ -311,12 +320,10 @@ final class PhamePostViewController ->setLimit(1); $prev = id(clone $query) - ->setAfterID($post->getID()) - ->execute(); + ->executeWithCursorPager($prev_pager); $next = id(clone $query) - ->setBeforeID($post->getID()) - ->execute(); + ->executeWithCursorPager($next_pager); return array(head($prev), head($next)); }