From c4392ba067575c5c5a6523df25dd5b341bcc1be4 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Wed, 24 May 2017 10:18:21 -0700 Subject: [PATCH] Add slugs to project manage page Summary: Minor, just shows the slugs on the manage project page, also normalized language to "details" Test Plan: review a project with slugs, description. Reviewers: amckinley Reviewed By: amckinley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D17985 --- .../project/controller/PhabricatorProjectController.php | 8 ++++++++ .../controller/PhabricatorProjectManageController.php | 7 ++++++- .../controller/PhabricatorProjectProfileController.php | 2 +- 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/src/applications/project/controller/PhabricatorProjectController.php b/src/applications/project/controller/PhabricatorProjectController.php index 45e2f193af..7c344b0b8e 100644 --- a/src/applications/project/controller/PhabricatorProjectController.php +++ b/src/applications/project/controller/PhabricatorProjectController.php @@ -166,4 +166,12 @@ abstract class PhabricatorProjectController extends PhabricatorController { ->buildResponse(); } + public function renderHashtags(array $tags) { + $result = array(); + foreach ($tags as $key => $tag) { + $result[] = '#'.$tag; + } + return implode(', ', $result); + } + } diff --git a/src/applications/project/controller/PhabricatorProjectManageController.php b/src/applications/project/controller/PhabricatorProjectManageController.php index 17b9030658..2c76c63606 100644 --- a/src/applications/project/controller/PhabricatorProjectManageController.php +++ b/src/applications/project/controller/PhabricatorProjectManageController.php @@ -138,6 +138,12 @@ final class PhabricatorProjectManageController pht('Looks Like'), $viewer->renderHandle($project->getPHID())->setAsTag(true)); + $slugs = $project->getSlugs(); + $tags = mpull($slugs, 'getSlug'); + + $view->addProperty( + pht('Hashtags'), + $this->renderHashtags($tags)); $field_list = PhabricatorCustomField::getObjectFields( $project, @@ -147,5 +153,4 @@ final class PhabricatorProjectManageController return $view; } - } diff --git a/src/applications/project/controller/PhabricatorProjectProfileController.php b/src/applications/project/controller/PhabricatorProjectProfileController.php index 32dbec3c0f..e47cc678bc 100644 --- a/src/applications/project/controller/PhabricatorProjectProfileController.php +++ b/src/applications/project/controller/PhabricatorProjectProfileController.php @@ -135,7 +135,7 @@ final class PhabricatorProjectProfileController } $header = id(new PHUIHeaderView()) - ->setHeader(pht('Properties')); + ->setHeader(pht('Details')); $view = id(new PHUIObjectBoxView()) ->setHeader($header)