revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 08:42:41 +01:00
Code Issues Releases Wiki Activity

Tailor the "no reviewers on this revision" warnings to handle the case where all reviewers have resigned

Browse source 
Summary:
Ref T13216. See PHI985. We currently use a banner to warn you when a revision has no reviewers or only disabled users, but since the changes to track "Resign" more explicilty we'll no longer warn you if everyone has resigned.

(Previously, they'd no longer be reviewers, so you'd end up with the "no reviewers are assigned" warning if everyone resigned.)

This can still interact slightly oddly with some states (e.g., only a package or project reviewer) but I'd like to wait for T731 to tighten those cases up, and they're more advanced/unusual.

Test Plan:
{F6026832}

{F6026833}

{F6026834}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13216

Differential Revision: https://secure.phabricator.com/D19834
This commit is contained in:
epriestley 2018-11-24 06:41:34 -08:00
parent 01c7be059d
commit c457d23a1d
1 changed files with 20 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
src/applications/differential/customfield/DifferentialReviewersField.php
View file

@ -72,20 +72,35 @@ final class DifferentialReviewersField
return array(); return array();
} }
$all_resigned = true;
$all_disabled = true;
$any_reviewers = false;
foreach ($this->getValue() as $reviewer) { foreach ($this->getValue() as $reviewer) {
if (!$handles[$reviewer->getReviewerPHID()]->isDisabled()) { $reviewer_phid = $reviewer->getReviewerPHID();
return array();
$any_reviewers = true;
if (!$handles[$reviewer_phid]->isDisabled()) {
$all_disabled = false;
}
if (!$reviewer->isResigned()) {
$all_resigned = false;
} }
} }
$warnings = array(); $warnings = array();
if ($this->getValue()) { if (!$any_reviewers) {
$warnings[] = pht(
'This revision needs review, but there are no reviewers specified.');
} else if ($all_disabled) {
$warnings[] = pht( $warnings[] = pht(
'This revision needs review, but all specified reviewers are '. 'This revision needs review, but all specified reviewers are '.
'disabled or inactive.'); 'disabled or inactive.');
} else { } else if ($all_resigned) {
$warnings[] = pht( $warnings[] = pht(
'This revision needs review, but there are no reviewers specified.'); 'This revision needs review, but all reviewers have resigned.');
} }
return $warnings; return $warnings;