Minor cleanup for task rendering in Daemons

Summary:
Fixes two issues:

  - When rendering a task's details, we currently issue a policy-oblivious query. Instead, issue a policy-aware query.
  - The formatting is a little bit weird, with the top half in a box and the bottom half with an older style. Make them consistent.

Test Plan: Looked at the detail pages for several tasks in queue.

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D7812

src/applications/daemon/controller/PhabricatorWorkerTaskDetailController.php

@@ -41,19 +41,23 @@ final class PhabricatorWorkerTaskDetailController
       $actions = $this->buildActionListView($task);
       $properties = $this->buildPropertyListView($task, $actions);
 
+      $object_box = id(new PHUIObjectBoxView())
+        ->setHeader($header)
+        ->addPropertyList($properties);
+
+
       $retry_head = id(new PHUIHeaderView())
         ->setHeader(pht('Retries'));
 
       $retry_info = $this->buildRetryListView($task);
 
-      $object_box = id(new PHUIObjectBoxView())
+      $retry_box = id(new PHUIObjectBoxView())
-        ->setHeader($header)
+        ->setHeader($retry_head)
-        ->addPropertyList($properties);
+        ->addPropertyList($retry_info);
 
       $content = array(
         $object_box,
-        $retry_head,
+        $retry_box,
-        $retry_info,
       );
     }
 
@@ -118,6 +122,8 @@ final class PhabricatorWorkerTaskDetailController
     PhabricatorWorkerTask $task,
     PhabricatorActionListView $actions) {
 
+    $viewer = $this->getRequest()->getUser();
+
     $view = new PHUIPropertyListView();
     $view->setActionList($actions);
 
@@ -191,7 +197,7 @@ final class PhabricatorWorkerTaskDetailController
     $data = id(new PhabricatorWorkerTaskData())->load($task->getDataID());
     $task->setData($data->getData());
     $worker = $task->getWorkerInstance();
-    $data = $worker->renderForDisplay();
+    $data = $worker->renderForDisplay($viewer);
 
     $view->addProperty(
       pht('Data'),

src/applications/metamta/PhabricatorMetaMTAWorker.php

@@ -41,7 +41,7 @@ final class PhabricatorMetaMTAWorker
     return $this->message;
   }
 
-  public function renderForDisplay() {
+  public function renderForDisplay(PhabricatorUser $viewer) {
     return phutil_tag(
       'pre',
       array(

src/applications/repository/worker/PhabricatorRepositoryCommitParserWorker.php

@@ -64,19 +64,21 @@ abstract class PhabricatorRepositoryCommitParserWorker
     return (bool)$bad_commit;
   }
 
-  public function renderForDisplay() {
+  public function renderForDisplay(PhabricatorUser $viewer) {
-    $suffix = parent::renderForDisplay();
+    $suffix = parent::renderForDisplay($viewer);
-    $commit = $this->loadCommit();
+
+    $commit = id(new DiffusionCommitQuery())
+      ->setViewer($viewer)
+      ->withIDs(array(idx($this->getTaskData(), 'commitID')))
+      ->executeOne();
     if (!$commit) {
       return $suffix;
     }
 
-    // TODO: (T603) This method should probably take a viewer.
+    $link = DiffusionView::linkCommit(
+      $commit->getRepository(),
+      $commit->getCommitIdentifier());
 
-    $repository = id(new PhabricatorRepository())
+    return array($link, $suffix);
-      ->load($commit->getRepositoryID());
-    $link = DiffusionView::linkCommit($repository,
-                                      $commit->getCommitIdentifier());
-    return hsprintf('%s%s', $link, $suffix);
   }
 }

src/infrastructure/daemon/workers/PhabricatorWorker.php

@@ -154,7 +154,7 @@ abstract class PhabricatorWorker {
     }
   }
 
-  public function renderForDisplay() {
+  public function renderForDisplay(PhabricatorUser $viewer) {
     $data = PhutilReadableSerializer::printableValue($this->data);
     return phutil_tag('pre', array(), $data);
   }