revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-19 18:28:39 +01:00
Code Issues Releases Wiki Activity

Correct an issue where the wrong "Content-Length" was set for partial content responses

Browse source 
Summary: Ref T8266. Although we compute this correctly above, we ignored it when actually setting the header. Use the computed value to set the "Content-Length" header. This is consistent with the spec/documentation.

Test Plan: Before, some audio (like `rain.mp3`) was pretty spotty about loading in Safari. It now loads consistently for me locally.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8266

Differential Revision: https://secure.phabricator.com/D17624
This commit is contained in:
epriestley 2017-04-05 06:46:26 -07:00
parent 45fc4f6f64
commit c4c3de7bfa
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/aphront/response/AphrontFileResponse.php
View file

@ -105,7 +105,7 @@ final class AphrontFileResponse extends AphrontResponse {
} }
if (!$this->shouldCompressResponse()) { if (!$this->shouldCompressResponse()) {
$headers[] = array('Content-Length', $this->getContentLength()); $headers[] = array('Content-Length', $content_len);
} }
if (strlen($this->getDownload())) { if (strlen($this->getDownload())) {