From c4df80b39e3bc553b18b7e595f3a7d1ab7b5673c Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Wed, 23 Dec 2015 11:29:00 -0800
Subject: [PATCH] Remove various unused beahviors from PHUIWorkboardView

Summary: Ref T5240. We don't currently use any of these options and I don't think we have any plans to use them. Strip them out for now to make fixing drag-and-drop stuff easier.

Test Plan: Grepped for removed stuff, no hits.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T5240

Differential Revision: https://secure.phabricator.com/D14864
---
 resources/celerity/map.php                    |  4 +-
 src/view/phui/PHUIWorkboardView.php           | 47 +-----------------
 webroot/rsrc/css/phui/phui-workboard-view.css | 48 -------------------
 3 files changed, 3 insertions(+), 96 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 309f9b8b01..6eed658f34 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -152,7 +152,7 @@ return array(
     'rsrc/css/phui/phui-text.css' => 'cf019f54',
     'rsrc/css/phui/phui-timeline-view.css' => '2efceff8',
     'rsrc/css/phui/phui-two-column-view.css' => '39ecafb1',
-    'rsrc/css/phui/phui-workboard-view.css' => '6704d68d',
+    'rsrc/css/phui/phui-workboard-view.css' => '24fe2a66',
     'rsrc/css/phui/phui-workpanel-view.css' => 'adec7699',
     'rsrc/css/sprite-login.css' => '60e8560e',
     'rsrc/css/sprite-main-header.css' => 'f07bbb87',
@@ -828,7 +828,7 @@ return array(
     'phui-theme-css' => '6b451f24',
     'phui-timeline-view-css' => '2efceff8',
     'phui-two-column-view-css' => '39ecafb1',
-    'phui-workboard-view-css' => '6704d68d',
+    'phui-workboard-view-css' => '24fe2a66',
     'phui-workpanel-view-css' => 'adec7699',
     'phuix-action-list-view' => 'b5c256b8',
     'phuix-action-view' => '8cf6d262',
diff --git a/src/view/phui/PHUIWorkboardView.php b/src/view/phui/PHUIWorkboardView.php
index 04a0941d70..45061f25fe 100644
--- a/src/view/phui/PHUIWorkboardView.php
+++ b/src/view/phui/PHUIWorkboardView.php
@@ -3,8 +3,6 @@
 final class PHUIWorkboardView extends AphrontTagView {
 
   private $panels = array();
-  private $fluidLayout = false;
-  private $fluidishLayout = false;
   private $actions = array();
 
   public function addPanel(PHUIWorkpanelView $panel) {
@@ -12,21 +10,6 @@ final class PHUIWorkboardView extends AphrontTagView {
     return $this;
   }
 
-  public function setFluidLayout($layout) {
-    $this->fluidLayout = $layout;
-    return $this;
-  }
-
-  public function setFluidishLayout($layout) {
-    $this->fluidishLayout = $layout;
-    return $this;
-  }
-
-  public function addAction(PHUIIconView $action) {
-    $this->actions[] = $action;
-    return $this;
-  }
-
   protected function getTagAttributes() {
     return array(
       'class' => 'phui-workboard-view',
@@ -36,33 +19,8 @@ final class PHUIWorkboardView extends AphrontTagView {
   protected function getTagContent() {
     require_celerity_resource('phui-workboard-view-css');
 
-    $action_list = null;
-    if (!empty($this->actions)) {
-      $items = array();
-      foreach ($this->actions as $action) {
-        $items[] = phutil_tag(
-          'li',
-            array(
-              'class' => 'phui-workboard-action-item',
-            ),
-            $action);
-      }
-      $action_list = phutil_tag(
-        'ul',
-          array(
-            'class' => 'phui-workboard-action-list',
-          ),
-          $items);
-    }
-
     $view = new AphrontMultiColumnView();
     $view->setGutter(AphrontMultiColumnView::GUTTER_MEDIUM);
-    if ($this->fluidLayout) {
-      $view->setFluidLayout($this->fluidLayout);
-    }
-    if ($this->fluidishLayout) {
-      $view->setFluidishLayout($this->fluidishLayout);
-    }
     foreach ($this->panels as $panel) {
       $view->addColumn($panel);
     }
@@ -74,9 +32,6 @@ final class PHUIWorkboardView extends AphrontTagView {
         ),
         $view);
 
-    return array(
-      $action_list,
-      $board,
-    );
+    return $board;
   }
 }
diff --git a/webroot/rsrc/css/phui/phui-workboard-view.css b/webroot/rsrc/css/phui/phui-workboard-view.css
index 2befbd7823..e6817c6254 100644
--- a/webroot/rsrc/css/phui/phui-workboard-view.css
+++ b/webroot/rsrc/css/phui/phui-workboard-view.css
@@ -37,54 +37,6 @@
   background: {$lightbluetext};
 }
 
-.phui-workboard-action-list {
-  width: 60px;
-  float: left;
-  min-height: 60px;
-  border-radius: 5px;
-  margin-right: 8px;
-  background: {$lightbluebackground};
-  border: 1px solid {$lightblueborder};
-  border-bottom: 1px solid {$blueborder};
-}
-
-.device-phone .phui-workboard-action-list {
-  width: 100%;
-  float: none;
-  display: block;
-  overflow: hidden;
-  border: none;
-  background: none;
-  border-radius: none;
-  min-height: 0;
-}
-
-.phui-workboard-action-list li:first-child {
-  padding-top: 5px;
-}
-
-.device-phone .phui-workboard-action-list li {
-  display: inline;
-  float: left;
-  margin: 0;
-  padding: 0 0 8px 0;
-}
-
-.phui-workboard-action-list .phui-icon-view {
-  display: inline-block;
-  vertical-align: top;
-  width: 50px;
-  height: 50px;
-  margin: 0 4px 5px 5px;
-}
-
-.device-phone .phui-workboard-action-list .phui-icon-view {
-  background-size: 35px;
-  height: 35px;
-  width: 35px;
-  margin: 0 3px;
-}
-
 .device-desktop .project-board-wrapper .phui-workboard-view-shadow {
   left: 53px;
 }