revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 09:12:41 +01:00
Code Issues Releases Wiki Activity

Differential - fix bogus foreach(null)

Browse source 
Summary: Default $phids to array() and update it if getValue() has something pertinent... Fixes T6292.

Test Plan: just used the ole logic noodle on this one.

Reviewers: chad, epriestley

Reviewed By: chad, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6292

Differential Revision: https://secure.phabricator.com/D10697
This commit is contained in:
Bob Trahan 2014-10-13 12:57:08 -07:00
parent c728c0ac60
commit c51489f138
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/differential/customfield/DifferentialReviewersField.php
View file

@ -63,7 +63,11 @@ final class DifferentialReviewersField
}
public function getRequiredHandlePHIDsForEdit() {
return mpull($this->getValue(), 'getReviewerPHID');
$phids = array();
if ($this->getValue()) {
$phids = mpull($this->getValue(), 'getReviewerPHID');
}
return $phids;
}
public function renderEditControl(array $handles) {