add "update" mode to Diffusion coverage Conduit

Summary:
This diff adds a new mode argument to the Diffusion Conduit API with two options:
- "overwrite": the default, maintains the current behavior of deleting all coverage
  in the specified branch before uploading the new coverage
- "update": does not delete old coverage, but will overwrite previous
  coverage information if it's for the same file and commit

`DiffusionRequest::loadCoverage` already loads a file's coverage from the
latest available commit, so uploading coverage for different files in different
commits with "update" will result in seeing the latest uploaded coverage in
Diffusion.

Test Plan: manual local verification

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14428

resources/sql/autopatches/20151109.repository.coverage.1.sql

@@ -0,0 +1,8 @@
+USE {$NAMESPACE}_repository;
+DELETE x FROM repository_coverage x
+LEFT JOIN repository_coverage y
+  ON  x.branchID = y.branchID
+  AND x.commitID = y.commitID
+  AND x.pathID = y.pathID
+  AND y.id > x.id
+  WHERE y.id IS NOT NULL;

src/applications/diffusion/conduit/DiffusionUpdateCoverageConduitAPIMethod.php

@@ -20,11 +20,17 @@ final class DiffusionUpdateCoverageConduitAPIMethod
   }
 
   protected function defineParamTypes() {
+    $modes = array(
+      'overwrite',
+      'update',
+    );
+
     return array(
       'repositoryPHID' => 'required phid',
       'branch' => 'required string',
       'commit' => 'required string',
       'coverage' => 'required map<string, string>',
+      'mode' => 'optional '.$this->formatStringConstants($modes),
     );
   }
 
@@ -77,16 +83,31 @@ final class DiffusionUpdateCoverageConduitAPIMethod
     $table_name = 'repository_coverage';
 
     $conn->openTransaction();
-      queryfx(
+    $mode = $request->getValue('mode');
-        $conn,
+      switch ($mode) {
-        'DELETE FROM %T WHERE branchID = %d',
+        case '':
-        $table_name,
+        case 'overwrite':
-        $branch->getID());
+          // sets the coverage for the whole branch, deleting all previous
+          // coverage information
+          queryfx(
+            $conn,
+            'DELETE FROM %T WHERE branchID = %d',
+            $table_name,
+            $branch->getID());
+          break;
+        case 'update':
+          // sets the coverage for the provided files on the specified commit
+          break;
+        default:
+          $conn->killTransaction();
+          throw new Exception(pht('Invalid mode "%s".', $mode));
+      }
 
       foreach (PhabricatorLiskDAO::chunkSQL($sql) as $chunk) {
         queryfx(
           $conn,
-          'INSERT INTO %T (branchID, pathID, commitID, coverage) VALUES %Q',
+          'INSERT INTO %T (branchID, pathID, commitID, coverage) VALUES %Q'.
+          ' ON DUPLICATE KEY UPDATE coverage=VALUES(coverage)',
           $table_name,
           $chunk);
       }

src/applications/repository/storage/PhabricatorRepositorySchemaSpec.php

@@ -37,6 +37,7 @@ final class PhabricatorRepositorySchemaSpec
         ),
         'key_path' => array(
           'columns' => array('branchID', 'pathID', 'commitID'),
+          'unique' => true,
         ),
       ));