Unify user-select CSS directives

Summary:
Removes the -khtml, -moz and -ms prefix, since most Browsers are natively supporting the user select directive.
The -webkit prefix is still kept or added for Safari, wich does not support user-select.

Ref: see https://we.phorge.it/D25024#815 for context

Test Plan: Removing the CSS should change nothing in modern browsers.

Reviewers: O1 Blessed Committers, speck, valerio.bozzolan, Matthew

Reviewed By: O1 Blessed Committers, speck, valerio.bozzolan

Subscribers: Cigaryno, Matthew, speck, tobiaswiese, valerio.bozzolan

Differential Revision: https://we.phorge.it/D25025

resources/celerity/map.php

@@ -9,10 +9,10 @@ return array(
   'names' => array(
     'conpherence.pkg.css' => '0e3cf785',
     'conpherence.pkg.js' => '020aebcf',
-    'core.pkg.css' => '2ba11212',
+    'core.pkg.css' => '0cb47e9d',
     'core.pkg.js' => '2eeda9e0',
     'dark-console.pkg.js' => '187792c2',
-    'differential.pkg.css' => '609e63d4',
+    'differential.pkg.css' => '525f9a1d',
     'differential.pkg.js' => '46fcb3af',
     'diffusion.pkg.css' => '42c75c37',
     'diffusion.pkg.js' => '78c9885d',
@@ -41,7 +41,7 @@ return array(
     'rsrc/css/application/base/main-menu-view.css' => '89fc16b6',
     'rsrc/css/application/base/notification-menu.css' => '4df1ee30',
     'rsrc/css/application/base/phui-theme.css' => '35883b37',
-    'rsrc/css/application/base/standard-page-view.css' => 'a374f94c',
+    'rsrc/css/application/base/standard-page-view.css' => 'e08c7462',
     'rsrc/css/application/chatlog/chatlog.css' => 'abdc76ee',
     'rsrc/css/application/conduit/conduit-api.css' => 'ce2cfc41',
     'rsrc/css/application/config/config-options.css' => '16c920ae',
@@ -63,7 +63,7 @@ return array(
     'rsrc/css/application/diff/diff-tree-view.css' => 'e2d3e222',
     'rsrc/css/application/diff/inline-comment-summary.css' => '81eb368d',
     'rsrc/css/application/differential/add-comment.css' => '7e5900d9',
-    'rsrc/css/application/differential/changeset-view.css' => 'bf159129',
+    'rsrc/css/application/differential/changeset-view.css' => '8b9caefe',
     'rsrc/css/application/differential/core.css' => '7300a73e',
     'rsrc/css/application/differential/phui-inline-comment.css' => 'a864426f',
     'rsrc/css/application/differential/revision-comment.css' => '7dbc8d1d',
@@ -77,7 +77,7 @@ return array(
     'rsrc/css/application/feed/feed.css' => 'd8b6e3f8',
     'rsrc/css/application/files/global-drag-and-drop.css' => '1d2713a4',
     'rsrc/css/application/flag/flag.css' => '2b77be8d',
-    'rsrc/css/application/harbormaster/harbormaster.css' => 'd98decda',
+    'rsrc/css/application/harbormaster/harbormaster.css' => 'cd0ce059',
     'rsrc/css/application/herald/herald-test.css' => '7e7bbdae',
     'rsrc/css/application/herald/herald.css' => '648d39e2',
     'rsrc/css/application/maniphest/report.css' => '3d53188b',
@@ -110,7 +110,7 @@ return array(
     'rsrc/css/application/tokens/tokens.css' => 'ce5a50bd',
     'rsrc/css/application/uiexample/example.css' => 'b4795059',
     'rsrc/css/core/core.css' => 'a708bd25',
-    'rsrc/css/core/remarkup.css' => '5baa3bd9',
+    'rsrc/css/core/remarkup.css' => '3480e1fe',
     'rsrc/css/core/syntax.css' => '548567f6',
     'rsrc/css/core/z-index.css' => 'ac3bfcd4',
     'rsrc/css/diviner/diviner-shared.css' => '4bd263b0',
@@ -121,10 +121,10 @@ return array(
     'rsrc/css/fuel/fuel-handle-list.css' => '2c4cbeca',
     'rsrc/css/fuel/fuel-map.css' => 'd6e31510',
     'rsrc/css/fuel/fuel-menu.css' => '21f5d199',
-    'rsrc/css/layout/phabricator-source-code-view.css' => '6b31244f',
+    'rsrc/css/layout/phabricator-source-code-view.css' => '49656486',
     'rsrc/css/phui/button/phui-button-bar.css' => 'a4aa75c4',
     'rsrc/css/phui/button/phui-button-simple.css' => '1ff278aa',
-    'rsrc/css/phui/button/phui-button.css' => 'e434f171',
+    'rsrc/css/phui/button/phui-button.css' => 'f9d0f9c8',
     'rsrc/css/phui/calendar/phui-calendar-day.css' => '9597d706',
     'rsrc/css/phui/calendar/phui-calendar-list.css' => 'ccd7e4e2',
     'rsrc/css/phui/calendar/phui-calendar-month.css' => 'cb758c42',
@@ -133,7 +133,7 @@ return array(
     'rsrc/css/phui/object-item/phui-oi-color.css' => 'b517bfa0',
     'rsrc/css/phui/object-item/phui-oi-drag-ui.css' => 'da15d3dc',
     'rsrc/css/phui/object-item/phui-oi-flush-ui.css' => '490e2e2e',
-    'rsrc/css/phui/object-item/phui-oi-list-view.css' => 'af98a277',
+    'rsrc/css/phui/object-item/phui-oi-list-view.css' => '9275ff55',
     'rsrc/css/phui/object-item/phui-oi-simple-ui.css' => '6a30fa46',
     'rsrc/css/phui/phui-action-list.css' => '1b0085b2',
     'rsrc/css/phui/phui-action-panel.css' => '6c386cbf',
@@ -182,8 +182,8 @@ return array(
     'rsrc/css/phui/phui-two-column-view.css' => 'f96d319f',
     'rsrc/css/phui/workboards/phui-workboard-color.css' => '3a1c21ff',
     'rsrc/css/phui/workboards/phui-workboard.css' => '74fc9d98',
-    'rsrc/css/phui/workboards/phui-workcard.css' => '913441b6',
+    'rsrc/css/phui/workboards/phui-workcard.css' => '62056e3b',
-    'rsrc/css/phui/workboards/phui-workpanel.css' => '3ae89b20',
+    'rsrc/css/phui/workboards/phui-workpanel.css' => 'bc06f022',
     'rsrc/css/sprite-login.css' => '35d1510c',
     'rsrc/css/sprite-tokens.css' => 'f1896dc5',
     'rsrc/css/syntax/syntax-default.css' => '055fc231',
@@ -560,7 +560,7 @@ return array(
     'conpherence-transaction-css' => '3a3f5e7e',
     'd3' => '9d068042',
     'diff-tree-view-css' => 'e2d3e222',
-    'differential-changeset-view-css' => 'bf159129',
+    'differential-changeset-view-css' => '8b9caefe',
     'differential-core-view-css' => '7300a73e',
     'differential-revision-add-comment-css' => '7e5900d9',
     'differential-revision-comment-css' => '7dbc8d1d',
@@ -579,7 +579,7 @@ return array(
     'fuel-map-css' => 'd6e31510',
     'fuel-menu-css' => '21f5d199',
     'global-drag-and-drop-css' => '1d2713a4',
-    'harbormaster-css' => 'd98decda',
+    'harbormaster-css' => 'cd0ce059',
     'herald-css' => '648d39e2',
     'herald-rule-editor' => '2633bef7',
     'herald-test-css' => '7e7bbdae',
@@ -800,13 +800,13 @@ return array(
     'phabricator-object-selector-css' => 'ee77366f',
     'phabricator-phtize' => '2f1db1ed',
     'phabricator-prefab' => '5793d835',
-    'phabricator-remarkup-css' => '5baa3bd9',
+    'phabricator-remarkup-css' => '3480e1fe',
     'phabricator-remarkup-metadata' => 'e40c4991',
     'phabricator-search-results-css' => '9ea70ace',
     'phabricator-shaped-request' => '995f5102',
     'phabricator-slowvote-css' => '1694baed',
-    'phabricator-source-code-view-css' => '6b31244f',
+    'phabricator-source-code-view-css' => '49656486',
-    'phabricator-standard-page-view' => 'a374f94c',
+    'phabricator-standard-page-view' => 'e08c7462',
     'phabricator-textareautils' => 'f340a484',
     'phabricator-title' => '43bc9360',
     'phabricator-tooltip' => '83754533',
@@ -829,7 +829,7 @@ return array(
     'phui-box-css' => '5ed3b8cb',
     'phui-bulk-editor-css' => '374d5e30',
     'phui-button-bar-css' => 'a4aa75c4',
-    'phui-button-css' => 'e434f171',
+    'phui-button-css' => 'f9d0f9c8',
     'phui-button-simple-css' => '1ff278aa',
     'phui-calendar-css' => 'f11073aa',
     'phui-calendar-day-css' => '9597d706',
@@ -870,7 +870,7 @@ return array(
     'phui-oi-color-css' => 'b517bfa0',
     'phui-oi-drag-ui-css' => 'da15d3dc',
     'phui-oi-flush-ui-css' => '490e2e2e',
-    'phui-oi-list-view-css' => 'af98a277',
+    'phui-oi-list-view-css' => '9275ff55',
     'phui-oi-simple-ui-css' => '6a30fa46',
     'phui-pager-css' => 'd022c7ad',
     'phui-pinboard-view-css' => '1f08f5d8',
@@ -886,8 +886,8 @@ return array(
     'phui-two-column-view-css' => 'f96d319f',
     'phui-workboard-color-css' => '3a1c21ff',
     'phui-workboard-view-css' => '74fc9d98',
-    'phui-workcard-view-css' => '913441b6',
+    'phui-workcard-view-css' => '62056e3b',
-    'phui-workpanel-view-css' => '3ae89b20',
+    'phui-workpanel-view-css' => 'bc06f022',
     'phuix-action-list-view' => 'c68f183f',
     'phuix-action-view' => 'a8f573a9',
     'phuix-autocomplete' => '2fbe234d',
@@ -1247,9 +1247,6 @@ return array(
       'trigger-rule',
       'trigger-rule-type',
     ),
-    '3ae89b20' => array(
-      'phui-workcard-view-css',
-    ),
     '3b4899b0' => array(
       'javelin-behavior',
       'phabricator-prefab',
@@ -1702,6 +1699,9 @@ return array(
       'javelin-dom',
       'phabricator-busy',
     ),
+    '8b9caefe' => array(
+      'phui-inline-comment-view-css',
+    ),
     '8badee71' => array(
       'javelin-install',
       'javelin-util',
@@ -2002,8 +2002,8 @@ return array(
       'javelin-uri',
       'phabricator-notification',
     ),
-    'bf159129' => array(
+    'bc06f022' => array(
-      'phui-inline-comment-view-css',
+      'phui-workcard-view-css',
     ),
     'c03f2fb4' => array(
       'javelin-install',

src/infrastructure/markup/rule/PhabricatorKeyboardRemarkupRule.php

@@ -212,6 +212,7 @@ final class PhabricatorKeyboardRemarkupRule extends PhutilRemarkupRule {
         'line-height: 0.6rem;',
         'border-radius: 3px;',
         'box-shadow: inset 0 -1px 0 rgba(71, 87, 120, 0.08);',
+        '-webkit-user-select: none;',
         'user-select: none;',
         'background: #f7f7f7;',
         'border: 1px solid #C7CCD9;',

webroot/rsrc/css/application/base/standard-page-view.css

@@ -74,6 +74,7 @@ body.white-background {
   text-decoration: none;
   border-radius: 3px;
   box-shadow: inset 0 -1px 0 rgba({$alphablue}, 0.08);
+  -webkit-user-select: none;
   user-select: none;
   color: {$darkgreytext};
   background: {$lightgreybackground};

webroot/rsrc/css/application/differential/changeset-view.css

@@ -432,37 +432,27 @@ unselectable. */
 
 .differential-diff.copy-l > tbody > tr > td,
 .differential-diff.copy-r > tbody > tr > td {
-  -moz-user-select: none;
-  -ms-user-select: none;
   -webkit-user-select: none;
   user-select: none;
 }
 
 .differential-diff.copy-l > tbody > tr > td:nth-child(2) {
-  -moz-user-select: auto;
-  -ms-user-select: auto;
   -webkit-user-select: auto;
   user-select: auto;
 }
 
 .differential-diff.copy-l > tbody > tr > td.show-more:nth-child(2) {
-  -moz-user-select: none;
-  -ms-user-select: none;
   -webkit-user-select: none;
   user-select: none;
 }
 
 .differential-diff.copy-r > tbody > tr > td:nth-child(5) {
-  -moz-user-select: auto;
-  -ms-user-select: auto;
   -webkit-user-select: auto;
   user-select: auto;
 }
 
 .differential-diff.copy-l > tbody > tr.inline > td,
 .differential-diff.copy-r > tbody > tr.inline > td {
-  -moz-user-select: none;
-  -ms-user-select: none;
   -webkit-user-select: none;
   user-select: none;
 }

webroot/rsrc/css/application/harbormaster/harbormaster.css

@@ -44,10 +44,7 @@
   background-color: {$paste.highlight};
   border-right: 1px solid {$paste.border};
 
-  -moz-user-select: -moz-none;
-  -khtml-user-select: none;
   -webkit-user-select: none;
-  -ms-user-select: none;
   user-select: none;
 }
 

webroot/rsrc/css/core/remarkup.css

@@ -66,6 +66,7 @@
   line-height: 0.6rem;
   border-radius: 3px;
   box-shadow: inset 0 -1px 0 rgba({$alphablue},0.08);
+  -webkit-user-select: none;
   user-select: none;
   background: {$lightgreybackground};
   border: 1px solid {$lightgreyborder};

webroot/rsrc/css/layout/phabricator-source-code-view.css

@@ -76,10 +76,7 @@ th.phabricator-source-line a:hover {
 
 .phabricator-source-blame-skip,
 .phabricator-source-blame-info {
-  -moz-user-select: -moz-none;
-  -khtml-user-select: none;
   -webkit-user-select: none;
-  -ms-user-select: none;
   user-select: none;
 }
 

webroot/rsrc/css/phui/button/phui-button.css

@@ -9,8 +9,6 @@ input[type="submit"] {
   font: {$basefont};
   -webkit-font-smoothing: antialiased;
   -webkit-user-select: none;
-  -moz-user-select: none;
-  -ms-user-select: none;
   user-select: none;
 }
 

webroot/rsrc/css/phui/object-item/phui-oi-list-view.css

@@ -675,8 +675,8 @@ ul.phui-oi-list-view .phui-oi-selected
 
 .phui-oi-selectable {
   cursor: pointer;
-  user-select: none;
   -webkit-user-select: none;
+  user-select: none;
 }
 
 /* When the list selection state can be toggled on the client (as in the bulk

webroot/rsrc/css/phui/workboards/phui-workcard.css

@@ -28,9 +28,6 @@
 .phui-workcard.phui-oi .phui-oi-objname {
   -webkit-touch-callout: text;
   -webkit-user-select: text;
-  -khtml-user-select: text;
-  -moz-user-select: text;
-  -ms-user-select: text;
   user-select: text;
 }
 

webroot/rsrc/css/phui/workboards/phui-workpanel.css

@@ -29,9 +29,6 @@
 .phui-workboard-view {
   -webkit-touch-callout: none;
   -webkit-user-select: none;
-  -khtml-user-select: none;
-  -moz-user-select: none;
-  -ms-user-select: none;
   user-select: none;
 }