From c5c2b8ce5a679adaa1b5b8e7dd605ba78bf3ff3e Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Thu, 25 Jul 2024 20:33:14 +0200 Subject: [PATCH] Remove unused parameter from PhabricatorMailEmailEngine::newEmailThreadingHeaders() call Summary: `Method PhabricatorMailEmailEngine::newEmailThreadingHeaders() invoked with 1 parameter, 0 required.` Thus remove the parameter from its call in the same class. The called private function does `$mailer = $this->getMailer()` anyway. Test Plan: Read the code. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25747 --- src/applications/metamta/engine/PhabricatorMailEmailEngine.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/metamta/engine/PhabricatorMailEmailEngine.php b/src/applications/metamta/engine/PhabricatorMailEmailEngine.php index 4278aa96a1..872f417cb2 100644 --- a/src/applications/metamta/engine/PhabricatorMailEmailEngine.php +++ b/src/applications/metamta/engine/PhabricatorMailEmailEngine.php @@ -72,7 +72,7 @@ final class PhabricatorMailEmailEngine $message->setSubject($subject); $headers = $this->newEmailHeaders(); - foreach ($this->newEmailThreadingHeaders($mailer) as $threading_header) { + foreach ($this->newEmailThreadingHeaders() as $threading_header) { $headers[] = $threading_header; }