revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-30 01:10:58 +01:00
Code Issues Releases Wiki Activity

Allow arc project and branch showing up in diff emails

Browse source 
Summary: Add the arc project and branch fields in emails for revisions under review. I am not quite sure why we only show them for changes which is already accepted or needs revision. It would be nice to have them for changes under review too.

Test Plan: Create a new revision and check email

Reviewers: epriestley, lifeihuang, JoelB, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D8035
This commit is contained in:
Peng Li 2014-01-22 09:12:04 -08:00 committed by epriestley
parent 83ab275b0f
commit c5c9cd415d
2 changed files with 0 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/applications/differential/field/specification/DifferentialArcanistProjectFieldSpecification.php
View file

@ -36,13 +36,6 @@ final class DifferentialArcanistProjectFieldSpecification
} }
public function renderValueForMail($phase) { public function renderValueForMail($phase) {
$status = $this->getRevision()->getStatus();
if ($status != ArcanistDifferentialRevisionStatus::NEEDS_REVISION &&
$status != ArcanistDifferentialRevisionStatus::ACCEPTED) {
return null;
}
$diff = $this->getRevision()->loadActiveDiff(); $diff = $this->getRevision()->loadActiveDiff();
if ($diff) { if ($diff) {
$phid = $diff->getArcanistProjectPHID(); $phid = $diff->getArcanistProjectPHID();

7
src/applications/differential/field/specification/DifferentialBranchFieldSpecification.php
View file

@ -32,13 +32,6 @@ final class DifferentialBranchFieldSpecification
} }
public function renderValueForMail($phase) { public function renderValueForMail($phase) {
$status = $this->getRevision()->getStatus();
if ($status != ArcanistDifferentialRevisionStatus::NEEDS_REVISION &&
$status != ArcanistDifferentialRevisionStatus::ACCEPTED) {
return null;
}
$diff = $this->getRevision()->loadActiveDiff(); $diff = $this->getRevision()->loadActiveDiff();
if ($diff) { if ($diff) {
$description = $this->getBranchOrBookmarkDescription($diff); $description = $this->getBranchOrBookmarkDescription($diff);