Delete maniphest.enabled and phriction.enabled

Summary: @edward, you would need to delete these options from FB config to avoid setup warning.

Test Plan: /T1

Reviewers: epriestley, edward

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5620

conf/default.conf.php

@@ -1083,9 +1083,6 @@ return array(
 
 // -- Maniphest ------------------------------------------------------------- //
 
-  // Deprecated, use 'phabricator.uninstalled-applications' instead.
-  'maniphest.enabled' => true,
-
   // Array of custom fields for Maniphest tasks. For details on adding custom
   // fields to Maniphest, see "Maniphest User Guide: Adding Custom Fields".
   'maniphest.custom-fields' => array(),
@@ -1099,11 +1096,6 @@ return array(
   // Defaults to "needs triage".
   'maniphest.default-priority' => 90,
 
-// -- Phriction ------------------------------------------------------------- //
-
-  // Deprecated, use 'phabricator.uninstalled-applications' instead.
-  'phriction.enabled' => true,
-
 // -- Phame ----------------------------------------------------------------- //
 
   // Should Phame users have Disqus comment widget, and if so what's the

src/applications/maniphest/application/PhabricatorApplicationManiphest.php

@@ -10,13 +10,6 @@ final class PhabricatorApplicationManiphest extends PhabricatorApplication {
     return '/maniphest/';
   }
 
-  public function isInstalled() {
-    if (!PhabricatorEnv::getEnvConfig('maniphest.enabled')) {
-      return false;
-    }
-    return parent::isInstalled();
-  }
-
   public function getIconName() {
     return 'maniphest';
   }

src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php

@@ -13,9 +13,6 @@ final class PhabricatorManiphestConfigOptions
 
   public function getOptions() {
     return array(
-      $this->newOption('maniphest.enabled', 'bool', true)
-        ->setDescription(pht(
-          "Deprecated, use 'phabricator.uninstalled-applications' instead.")),
       $this->newOption('maniphest.custom-fields', 'wild', array())
         ->setSummary(pht("Custom Maniphest fields."))
         ->setDescription(

src/applications/phriction/application/PhabricatorApplicationPhriction.php

@@ -18,13 +18,6 @@ final class PhabricatorApplicationPhriction extends PhabricatorApplication {
     return PhabricatorEnv::getDoclink('article/Phriction_User_Guide.html');
   }
 
-  public function isInstalled() {
-    if (!PhabricatorEnv::getEnvConfig('phriction.enabled')) {
-      return false;
-    }
-    return parent::isInstalled();
-  }
-
   public function getTitleGlyph() {
     return "\xE2\x9A\xA1";
   }

src/applications/phriction/config/PhabricatorPhrictionConfigOptions.php

@@ -13,14 +13,6 @@ final class PhabricatorPhrictionConfigOptions
 
   public function getOptions() {
     return array(
-      $this->newOption('phriction.enabled', 'bool', true)
-        ->setBoolOptions(
-          array(
-            pht("Enable Phriction"),
-            pht("Disable Phriction"),
-          ))
-        ->setDescription(pht(
-          "Deprecated, use 'phabricator.uninstalled-applications' instead.")),
       $this->newOption(
         'metamta.phriction.subject-prefix', 'string', '[Phriction]')
         ->setDescription(pht("Subject prefix for Phriction email.")),