revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-20 04:20:55 +01:00
Code Issues Releases Wiki Activity

Make base64 the default SMTP encoding

Browse source 
Summary: Ref T11120. If this works, I'll just remove this option completely.

Test Plan: ¯\_(ツ)_/¯

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11120

Differential Revision: https://secure.phabricator.com/D16095
This commit is contained in:
epriestley 2016-06-09 13:17:58 -07:00
parent e6e4ddd03a
commit c694bd651b
1 changed files with 3 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/applications/config/option/PhabricatorPHPMailerConfigOptions.php
View file

@ -55,7 +55,7 @@ final class PhabricatorPHPMailerConfigOptions
$this->newOption('phpmailer.smtp-password', 'string', null) $this->newOption('phpmailer.smtp-password', 'string', null)
->setHidden(true) ->setHidden(true)
->setDescription(pht('Password for SMTP.')), ->setDescription(pht('Password for SMTP.')),
$this->newOption('phpmailer.smtp-encoding', 'string', '8bit') $this->newOption('phpmailer.smtp-encoding', 'string', 'base64')
->setSummary(pht('Configure how mail is encoded.')) ->setSummary(pht('Configure how mail is encoded.'))
->setDescription( ->setDescription(
pht( pht(
@ -64,14 +64,8 @@ final class PhabricatorPHPMailerConfigOptions
"encoding. If you're having trouble with mail being mangled or ". "encoding. If you're having trouble with mail being mangled or ".
"arriving with too many or too few newlines, you may try ". "arriving with too many or too few newlines, you may try ".
"adjusting this setting.\n\n". "adjusting this setting.\n\n".
"Supported values are `8bit` (default), `quoted-printable`, ". "Supported values are `8bit`, `quoted-printable`, ".
"`7bit`, `binary` and `base64`.\n\n". "`7bit`, `binary` and `base64`.")),
"The settings in the table below may work well.\n\n".
"| MTA | Setting | Notes\n".
"|-----|---------|------\n".
"| SendGrid via SMTP | `quoted-printable` | Double newlines under ".
"`8bit`.\n".
"| All Other MTAs | `8bit` | Default setting.")),
); );
} }