revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 12:00:55 +01:00
Code Issues Releases Wiki Activity

T5409, allow bin/remove to permanently destroy credential and everything associated with it

Browse source 
Summary: Fixes T5409, bin/remove permanently destroys credential

Test Plan: Add a passphrase, run bin/remove destroy K123 --trace, verify credential no longer exists

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T5409

Differential Revision: https://secure.phabricator.com/D10185
This commit is contained in:
lkassianik 2014-08-07 16:33:54 -07:00 committed by epriestley
parent 20d8b1bdd3
commit c6998207ab
2 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/applications/passphrase/storage/PassphraseCredential.php
View file

@ -1,7 +1,8 @@
<?php
final class PassphraseCredential extends PassphraseDAO
implements PhabricatorPolicyInterface {
implements PhabricatorPolicyInterface,
PhabricatorDestructibleInterface {
protected $name;
protected $credentialType;
@ -83,4 +84,19 @@ final class PassphraseCredential extends PassphraseDAO
return null;
}
/* -( PhabricatorDestructibleInterface )----------------------------------- */
public function destroyObjectPermanently(
PhabricatorDestructionEngine $engine) {
$this->openTransaction();
$secrets = id(new PassphraseSecret())->loadAllWhere(
'id = %d',
$this->getSecretID());
foreach ($secrets as $secret) {
$secret->delete();
}
$this->delete();
$this->saveTransaction();
}
}

2
src/applications/system/interface/PhabricatorDestructibleInterface.php
View file

@ -11,7 +11,7 @@ interface PhabricatorDestructibleInterface {
// TEMPLATE IMPLEMENTATION /////////////////////////////////////////////////////
/* -( PhabricatorDestructableInterface )----------------------------------- */
/* -( PhabricatorDestructibleInterface )----------------------------------- */
/*
public function destroyObjectPermanently(