From c69a1aa0504f22c4176b431b277a551d6088bf43 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 7 Feb 2011 11:46:01 -0800 Subject: [PATCH] Make differential.find work okayish Summary: Test Plan: Reviewers: CC: --- .../find/ConduitAPI_differential_find_Method.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/applications/conduit/method/differential/find/ConduitAPI_differential_find_Method.php b/src/applications/conduit/method/differential/find/ConduitAPI_differential_find_Method.php index 486ae78895..4632f39808 100644 --- a/src/applications/conduit/method/differential/find/ConduitAPI_differential_find_Method.php +++ b/src/applications/conduit/method/differential/find/ConduitAPI_differential_find_Method.php @@ -57,11 +57,14 @@ class ConduitAPI_differential_find_Method extends ConduitAPIMethod { ->loadRevisions(); $results = array(); - foreach ($data->getRevisions() as $revision) { + foreach ($revisions as $revision) { $diff = $revision->loadActiveDiff(); + if (!$diff) { + continue; + } $results[] = array( 'id' => $revision->getID(), - 'name' => $revision->getName(), + 'name' => $revision->getTitle(), 'statusName' => DifferentialRevisionStatus::getNameForRevisionStatus( $revision->getStatus()), 'sourcePath' => $diff->getSourcePath(),