revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 10:12:41 +01:00
Code Issues Releases Wiki Activity

Cleanup Countdown manual construction of monograms/uris

Browse source 
Summary: looked for places where Countdown monograms/uris were being constructed by hand, and updated with modern versions

Test Plan: clicked around the Countdown UI, looking for broken links

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: chad, Korvin

Maniphest Tasks: T12524

Differential Revision: https://secure.phabricator.com/D17665
This commit is contained in:
Austin McKinley 2017-04-12 13:24:41 -07:00
parent 6bf595b951
commit c6c25b055b
4 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/countdown/controller/PhabricatorCountdownViewController.php
View file

@ -28,7 +28,7 @@ final class PhabricatorCountdownViewController
$crumbs = $this $crumbs = $this
->buildApplicationCrumbs() ->buildApplicationCrumbs()
->addTextCrumb("C{$id}") ->addTextCrumb($countdown->getMonogram())
->setBorder(true); ->setBorder(true);
$epoch = $countdown->getEpoch(); $epoch = $countdown->getEpoch();

6
src/applications/countdown/phid/PhabricatorCountdownCountdownPHIDType.php
View file

@ -35,9 +35,9 @@ final class PhabricatorCountdownCountdownPHIDType extends PhabricatorPHIDType {
$name = $countdown->getTitle(); $name = $countdown->getTitle();
$id = $countdown->getID(); $id = $countdown->getID();
$handle->setName("C{$id}"); $handle->setName($countdown->getMonogram());
$handle->setFullName("C{$id}: {$name}"); $handle->setFullName(pht('%s: %s', $countdown->getMonogram(), $name));
$handle->setURI("/countdown/{$id}/"); $handle->setURI($countdown->getURI());
} }
} }

2
src/applications/countdown/query/PhabricatorCountdownSearchEngine.php
View file

@ -108,7 +108,7 @@ final class PhabricatorCountdownSearchEngine
$item = id(new PHUIObjectItemView()) $item = id(new PHUIObjectItemView())
->setUser($viewer) ->setUser($viewer)
->setObject($countdown) ->setObject($countdown)
->setObjectName("C{$id}") ->setObjectName($countdown->getMonogram())
->setHeader($countdown->getTitle()) ->setHeader($countdown->getTitle())
->setHref($this->getApplicationURI("{$id}/")) ->setHref($this->getApplicationURI("{$id}/"))
->addByline( ->addByline(

4
src/applications/countdown/view/PhabricatorCountdownView.php
View file

@ -14,12 +14,12 @@ final class PhabricatorCountdownView extends AphrontView {
require_celerity_resource('phabricator-countdown-css'); require_celerity_resource('phabricator-countdown-css');
$header_text = array( $header_text = array(
'C'.$countdown->getID(), $countdown->getMonogram(),
' ', ' ',
phutil_tag( phutil_tag(
'a', 'a',
array( array(
'href' => '/countdown/'.$countdown->getID(), 'href' => $countdown->getURI(),
), ),
$countdown->getTitle()), $countdown->getTitle()),
); );