mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-09 16:32:39 +01:00
Workboard: fix CTRL+click on "Create Task" and "Edit Task"
Summary: The CTRL+click now opens the links in a new tab, like any other normal link opened with CTRL+click. Note that the middle-click was already working. Closes T15157 Test Plan: - visit a Workboard - column > menu > mouse on "Create Task" - CTRL+click: open in new tab (→ now works) - normal click: open the pop-up (→ still works) - middle-click: open in new tab (→ still works) - column > single Task > mouse on "Edit" - CTRL+click: open in new tab (→ now works) - normal click: open the pop-up (→ still works) - middle-click: open in new tab (→ still works) Reviewers: O1 Blessed Committers, avivey Reviewed By: O1 Blessed Committers, avivey Subscribers: speck, tobiaswiese, Matthew, Cigaryno Maniphest Tasks: T15157 Differential Revision: https://we.phorge.it/D25072
This commit is contained in:
parent
b33e373503
commit
c6f56b8221
1 changed files with 14 additions and 0 deletions
|
@ -151,6 +151,13 @@ JX.install('WorkboardController', {
|
|||
},
|
||||
|
||||
_onaddcard: function(e) {
|
||||
|
||||
// Allow CTRL+click and maybe other actions
|
||||
if(!e.isNormalMouseEvent()) {
|
||||
e.stop();
|
||||
return;
|
||||
}
|
||||
|
||||
// We want the 'boards-dropdown-menu' behavior to see this event and
|
||||
// close the dropdown, but don't want to follow the link.
|
||||
e.prevent();
|
||||
|
@ -176,6 +183,13 @@ JX.install('WorkboardController', {
|
|||
},
|
||||
|
||||
_oneditcard: function(e) {
|
||||
|
||||
// Allow CTRL+click and maybe other actions
|
||||
if(!e.isNormalMouseEvent()) {
|
||||
e.stop();
|
||||
return;
|
||||
}
|
||||
|
||||
e.kill();
|
||||
|
||||
var column_node = e.getNode('project-column');
|
||||
|
|
Loading…
Reference in a new issue