From c6f9316a778bd0d481bb0d99d7bf7c4e64f77169 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 7 Oct 2013 11:18:00 -0700 Subject: [PATCH] Add missing `case` for personal ruls which create blocking reviewers Summary: Ref T1279. I only tested the global case. :O Test Plan: Created a personal "add me as blocking" rule. Reviewers: btrahan, zeeg Reviewed By: zeeg CC: aran Maniphest Tasks: T1279 Differential Revision: https://secure.phabricator.com/D7261 --- src/applications/herald/adapter/HeraldAdapter.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/herald/adapter/HeraldAdapter.php b/src/applications/herald/adapter/HeraldAdapter.php index ec0485ed21..eef7647115 100644 --- a/src/applications/herald/adapter/HeraldAdapter.php +++ b/src/applications/herald/adapter/HeraldAdapter.php @@ -530,7 +530,7 @@ abstract class HeraldAdapter { case self::ACTION_AUDIT: case self::ACTION_ASSIGN_TASK: case self::ACTION_ADD_REVIEWERS: - case self::ACTION_ADD_REVIEWERS: + case self::ACTION_ADD_BLOCKING_REVIEWERS: // For personal rules, force these actions to target the rule owner. $target = array($author_phid); break;